fix case sensitive naming #25764
Merged
fix case sensitive naming #25764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| HybridCompute.json | 2023-06-20-preview(72ba537) | 2023-06-20-preview(main) |
| Rule | Message |
|---|---|
|
The operation id has been changed from 'licenses_ListByResourceGroup' to 'Licenses_ListByResourceGroup'. This will impact generated code. New: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L267:7 Old: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L267:7 |
|
The operation id has been changed from 'licenses_ListBySubscription' to 'Licenses_ListBySubscription'. This will impact generated code. New: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L309:7 Old: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L309:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-06 | package-preview-2023-06(72ba537) | package-preview-2023-06(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources']. Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L2477 |
|
Tracked resource 'License' must have patch operation that at least supports the update of tags. Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L2585 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these. Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L3026 |
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1093 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or Update a Machine Extension Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1246 |
|
| Based on the response model schema, operation 'NetworkProfile_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1675 |
|
| Based on the response model schema, operation 'AgentVersion_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1841 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GET Agent Versions Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1920 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=385213&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️❌ azure-sdk-for-net-track2 failed [Detail]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌Azure.ResourceManager.HybridCompute [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-hybridcompute [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation MachinesOperations.begin_assess_patches info [Changelog] - Added operation MachinesOperations.begin_install_patches info [Changelog] - Added operation group AgentVersionOperations info [Changelog] - Added operation group ExtensionMetadataOperations info [Changelog] - Added operation group HybridIdentityMetadataOperations info [Changelog] - Added operation group LicenseProfilesOperations info [Changelog] - Added operation group LicensesOperations info [Changelog] - Added operation group NetworkProfileOperations info [Changelog] - Model AgentConfiguration has a new parameter config_mode info [Changelog] - Model Machine has a new parameter ad_fqdn info [Changelog] - Model Machine has a new parameter agent_configuration info [Changelog] - Model Machine has a new parameter agent_upgrade info [Changelog] - Model Machine has a new parameter agent_version info [Changelog] - Model Machine has a new parameter client_public_key info [Changelog] - Model Machine has a new parameter cloud_metadata info [Changelog] - Model Machine has a new parameter detected_properties info [Changelog] - Model Machine has a new parameter display_name info [Changelog] - Model Machine has a new parameter dns_fqdn info [Changelog] - Model Machine has a new parameter domain_name info [Changelog] - Model Machine has a new parameter error_details info [Changelog] - Model Machine has a new parameter extensions info [Changelog] - Model Machine has a new parameter kind info [Changelog] - Model Machine has a new parameter last_status_change info [Changelog] - Model Machine has a new parameter license_profile info [Changelog] - Model Machine has a new parameter location_data info [Changelog] - Model Machine has a new parameter machine_fqdn info [Changelog] - Model Machine has a new parameter mssql_discovered info [Changelog] - Model Machine has a new parameter network_profile info [Changelog] - Model Machine has a new parameter os_name info [Changelog] - Model Machine has a new parameter os_profile info [Changelog] - Model Machine has a new parameter os_sku info [Changelog] - Model Machine has a new parameter os_type info [Changelog] - Model Machine has a new parameter os_version info [Changelog] - Model Machine has a new parameter parent_cluster_resource_id info [Changelog] - Model Machine has a new parameter private_link_scope_resource_id info [Changelog] - Model Machine has a new parameter provisioning_state info [Changelog] - Model Machine has a new parameter resources info [Changelog] - Model Machine has a new parameter service_statuses info [Changelog] - Model Machine has a new parameter status info [Changelog] - Model Machine has a new parameter vm_id info [Changelog] - Model Machine has a new parameter vm_uuid info [Changelog] - Model MachineExtensionUpdate has a new parameter auto_upgrade_minor_version info [Changelog] - Model MachineExtensionUpdate has a new parameter enable_automatic_upgrade info [Changelog] - Model MachineExtensionUpdate has a new parameter force_update_tag info [Changelog] - Model MachineExtensionUpdate has a new parameter protected_settings info [Changelog] - Model MachineExtensionUpdate has a new parameter publisher info [Changelog] - Model MachineExtensionUpdate has a new parameter settings info [Changelog] - Model MachineExtensionUpdate has a new parameter type info [Changelog] - Model MachineExtensionUpdate has a new parameter type_handler_version info [Changelog] - Model MachineUpdate has a new parameter agent_upgrade info [Changelog] - Model MachineUpdate has a new parameter cloud_metadata info [Changelog] - Model MachineUpdate has a new parameter kind info [Changelog] - Model MachineUpdate has a new parameter location_data info [Changelog] - Model MachineUpdate has a new parameter os_profile info [Changelog] - Model MachineUpdate has a new parameter parent_cluster_resource_id info [Changelog] - Model MachineUpdate has a new parameter private_link_scope_resource_id info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] - Operation MachinesOperations.list_by_resource_group has a new optional parameter expand info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model Machine no longer has parameter properties info [Changelog] - Model MachineExtensionUpdate no longer has parameter properties info [Changelog] - Model MachineUpdate no longer has parameter properties
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-hybridcompute [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `any` to `map[string]any` info [Changelog] - Type of `MachineExtensionProperties.Settings` has been changed from `any` to `map[string]any` info [Changelog] - Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `map[string]any` info [Changelog] - Type of `MachineExtensionUpdateProperties.Settings` has been changed from `any` to `map[string]any` info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `AgentConfigurationMode` with values `AgentConfigurationModeFull`, `AgentConfigurationModeMonitor` info [Changelog] - New enum type `ArcKindEnum` with values `ArcKindEnumAVS`, `ArcKindEnumAWS`, `ArcKindEnumEPS`, `ArcKindEnumGCP`, `ArcKindEnumHCI`, `ArcKindEnumSCVMM`, `ArcKindEnumVMware` info [Changelog] - New enum type `EsuEligibility` with values `EsuEligibilityEligible`, `EsuEligibilityIneligible`, `EsuEligibilityUnknown` info [Changelog] - New enum type `EsuKeyState` with values `EsuKeyStateActive`, `EsuKeyStateInactive` info [Changelog] - New enum type `EsuServerType` with values `EsuServerTypeDatacenter`, `EsuServerTypeStandard` info [Changelog] - New enum type `LastAttemptStatusEnum` with values `LastAttemptStatusEnumFailed`, `LastAttemptStatusEnumSuccess` info [Changelog] - New enum type `LicenseAssignmentState` with values `LicenseAssignmentStateAssigned`, `LicenseAssignmentStateNotAssigned` info [Changelog] - New enum type `LicenseCoreType` with values `LicenseCoreTypePCore`, `LicenseCoreTypeVCore` info [Changelog] - New enum type `LicenseEdition` with values `LicenseEditionDatacenter`, `LicenseEditionStandard` info [Changelog] - New enum type `LicenseState` with values `LicenseStateActivated`, `LicenseStateDeactivated` info [Changelog] - New enum type `LicenseTarget` with values `LicenseTargetWindowsServer2012`, `LicenseTargetWindowsServer2012R2` info [Changelog] - New enum type `LicenseType` with values `LicenseTypeESU` info [Changelog] - New enum type `OsType` with values `OsTypeLinux`, `OsTypeWindows` info [Changelog] - New enum type `PatchOperationStartedBy` with values `PatchOperationStartedByPlatform`, `PatchOperationStartedByUser` info [Changelog] - New enum type `PatchOperationStatus` with values `PatchOperationStatusCompletedWithWarnings`, `PatchOperationStatusFailed`, `PatchOperationStatusInProgress`, `PatchOperationStatusSucceeded`, `PatchOperationStatusUnknown` info [Changelog] - New enum type `PatchServiceUsed` with values `PatchServiceUsedAPT`, `PatchServiceUsedUnknown`, `PatchServiceUsedWU`, `PatchServiceUsedWUWSUS`, `PatchServiceUsedYUM`, `PatchServiceUsedZypper` info [Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleted`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating` info [Changelog] - New enum type `VMGuestPatchClassificationLinux` with values `VMGuestPatchClassificationLinuxCritical`, `VMGuestPatchClassificationLinuxOther`, `VMGuestPatchClassificationLinuxSecurity` info [Changelog] - New enum type `VMGuestPatchClassificationWindows` with values `VMGuestPatchClassificationWindowsCritical`, `VMGuestPatchClassificationWindowsDefinition`, `VMGuestPatchClassificationWindowsFeaturePack`, `VMGuestPatchClassificationWindowsSecurity`, `VMGuestPatchClassificationWindowsServicePack`, `VMGuestPatchClassificationWindowsTools`, `VMGuestPatchClassificationWindowsUpdateRollUp`, `VMGuestPatchClassificationWindowsUpdates` info [Changelog] - New enum type `VMGuestPatchRebootSetting` with values `VMGuestPatchRebootSettingAlways`, `VMGuestPatchRebootSettingIfRequired`, `VMGuestPatchRebootSettingNever` info [Changelog] - New enum type `VMGuestPatchRebootStatus` with values `VMGuestPatchRebootStatusCompleted`, `VMGuestPatchRebootStatusFailed`, `VMGuestPatchRebootStatusNotNeeded`, `VMGuestPatchRebootStatusRequired`, `VMGuestPatchRebootStatusStarted`, `VMGuestPatchRebootStatusUnknown` info [Changelog] - New function `NewAgentVersionClient(azcore.TokenCredential, *arm.ClientOptions) (*AgentVersionClient, error)` info [Changelog] - New function `*AgentVersionClient.Get(context.Context, string, string, *AgentVersionClientGetOptions) (AgentVersionClientGetResponse, error)` info [Changelog] - New function `*AgentVersionClient.List(context.Context, string, *AgentVersionClientListOptions) (AgentVersionClientListResponse, error)` info [Changelog] - New function `*ClientFactory.NewAgentVersionClient() *AgentVersionClient` info [Changelog] - New function `*ClientFactory.NewExtensionMetadataClient() *ExtensionMetadataClient` info [Changelog] - New function `*ClientFactory.NewHybridIdentityMetadataClient() *HybridIdentityMetadataClient` info [Changelog] - New function `*ClientFactory.NewLicenseProfilesClient() *LicenseProfilesClient` info [Changelog] - New function `*ClientFactory.NewLicensesClient() *LicensesClient` info [Changelog] - New function `*ClientFactory.NewNetworkProfileClient() *NetworkProfileClient` info [Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)` info [Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)` info [Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]` info [Changelog] - New function `NewHybridIdentityMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*HybridIdentityMetadataClient, error)` info [Changelog] - New function `*HybridIdentityMetadataClient.Get(context.Context, string, string, string, *HybridIdentityMetadataClientGetOptions) (HybridIdentityMetadataClientGetResponse, error)` info [Changelog] - New function `*HybridIdentityMetadataClient.NewListByMachinesPager(string, string, *HybridIdentityMetadataClientListByMachinesOptions) *runtime.Pager[HybridIdentityMetadataClientListByMachinesResponse]` info [Changelog] - New function `NewLicenseProfilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LicenseProfilesClient, error)` info [Changelog] - New function `*LicenseProfilesClient.BeginCreateOrUpdate(context.Context, string, string, LicenseProfile, *LicenseProfilesClientBeginCreateOrUpdateOptions) (*runtime.Poller[LicenseProfilesClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*LicenseProfilesClient.BeginDelete(context.Context, string, string, *LicenseProfilesClientBeginDeleteOptions) (*runtime.Poller[LicenseProfilesClientDeleteResponse], error)` info [Changelog] - New function `*LicenseProfilesClient.Get(context.Context, string, string, *LicenseProfilesClientGetOptions) (LicenseProfilesClientGetResponse, error)` info [Changelog] - New function `*LicenseProfilesClient.NewListPager(string, string, *LicenseProfilesClientListOptions) *runtime.Pager[LicenseProfilesClientListResponse]` info [Changelog] - New function `*LicenseProfilesClient.BeginUpdate(context.Context, string, string, LicenseProfileUpdate, *LicenseProfilesClientBeginUpdateOptions) (*runtime.Poller[LicenseProfilesClientUpdateResponse], error)` info [Changelog] - New function `NewLicensesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LicensesClient, error)` info [Changelog] - New function `*LicensesClient.BeginCreateOrUpdate(context.Context, string, string, License, *LicensesClientBeginCreateOrUpdateOptions) (*runtime.Poller[LicensesClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*LicensesClient.BeginDelete(context.Context, string, string, *LicensesClientBeginDeleteOptions) (*runtime.Poller[LicensesClientDeleteResponse], error)` info [Changelog] - New function `*LicensesClient.Get(context.Context, string, string, *LicensesClientGetOptions) (LicensesClientGetResponse, error)` info [Changelog] - New function `*LicensesClient.NewListByResourceGroupPager(string, *LicensesClientListByResourceGroupOptions) *runtime.Pager[LicensesClientListByResourceGroupResponse]` info [Changelog] - New function `*LicensesClient.NewListBySubscriptionPager(*LicensesClientListBySubscriptionOptions) *runtime.Pager[LicensesClientListBySubscriptionResponse]` info [Changelog] - New function `*LicensesClient.BeginUpdate(context.Context, string, string, LicenseUpdate, *LicensesClientBeginUpdateOptions) (*runtime.Poller[LicensesClientUpdateResponse], error)` info [Changelog] - New function `*LicensesClient.BeginValidateLicense(context.Context, License, *LicensesClientBeginValidateLicenseOptions) (*runtime.Poller[LicensesClientValidateLicenseResponse], error)` info [Changelog] - New function `*MachinesClient.BeginAssessPatches(context.Context, string, string, *MachinesClientBeginAssessPatchesOptions) (*runtime.Poller[MachinesClientAssessPatchesResponse], error)` info [Changelog] - New function `*MachinesClient.BeginInstallPatches(context.Context, string, string, MachineInstallPatchesParameters, *MachinesClientBeginInstallPatchesOptions) (*runtime.Poller[MachinesClientInstallPatchesResponse], error)` info [Changelog] - New function `NewNetworkProfileClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkProfileClient, error)` info [Changelog] - New function `*NetworkProfileClient.Get(context.Context, string, string, *NetworkProfileClientGetOptions) (NetworkProfileClientGetResponse, error)` info [Changelog] - New struct `AgentUpgrade` info [Changelog] - New struct `AgentVersion` info [Changelog] - New struct `AgentVersionsList` info [Changelog] - New struct `AvailablePatchCountByClassification` info [Changelog] - New struct `ErrorDetailAutoGenerated` info [Changelog] - New struct `ErrorResponseAutoGenerated` info [Changelog] - New struct `EsuKey` info [Changelog] - New struct `EsuProfileUpdateProperties` info [Changelog] - New struct `ExtensionValue` info [Changelog] - New struct `ExtensionValueListResult` info [Changelog] - New struct `ExtensionValueProperties` info [Changelog] - New struct `HybridIdentityMetadata` info [Changelog] - New struct `HybridIdentityMetadataList` info [Changelog] - New struct `HybridIdentityMetadataProperties` info [Changelog] - New struct `IPAddress` info [Changelog] - New struct `License` info [Changelog] - New struct `LicenseDetails` info [Changelog] - New struct `LicenseProfile` info [Changelog] - New struct `LicenseProfileArmEsuProperties` info [Changelog] - New struct `LicenseProfileArmEsuPropertiesWithoutAssignedLicense` info [Changelog] - New struct `LicenseProfileMachineInstanceView` info [Changelog] - New struct `LicenseProfileMachineInstanceViewEsuProperties` info [Changelog] - New struct `LicenseProfileProperties` info [Changelog] - New struct `LicenseProfileStorageModelEsuProperties` info [Changelog] - New struct `LicenseProfileUpdate` info [Changelog] - New struct `LicenseProfileUpdateProperties` info [Changelog] - New struct `LicenseProfilesListResult` info [Changelog] - New struct `LicenseProperties` info [Changelog] - New struct `LicenseUpdate` info [Changelog] - New struct `LicenseUpdateProperties` info [Changelog] - New struct `LicenseUpdatePropertiesLicenseDetails` info [Changelog] - New struct `LicensesListResult` info [Changelog] - New struct `LinuxParameters` info [Changelog] - New struct `MachineAssessPatchesResult` info [Changelog] - New struct `MachineInstallPatchesParameters` info [Changelog] - New struct `MachineInstallPatchesResult` info [Changelog] - New struct `NetworkInterface` info [Changelog] - New struct `NetworkProfile` info [Changelog] - New struct `Subnet` info [Changelog] - New struct `WindowsParameters` info [Changelog] - New field `ConfigMode` in struct `AgentConfiguration` info [Changelog] - New field `Kind`, `Resources` in struct `Machine` info [Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties` info [Changelog] - New field `AgentUpgrade`, `LicenseProfile`, `NetworkProfile` in struct `MachineProperties` info [Changelog] - New field `Kind` in struct `MachineUpdate` info [Changelog] - New field `AgentUpgrade` in struct `MachineUpdateProperties` info [Changelog] - New field `Expand` in struct `MachinesClientCreateOrUpdateOptions` info [Changelog] - New field `Expand` in struct `MachinesClientListByResourceGroupOptions` info [Changelog] - New field `SystemData` in struct `ProxyResource` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] - New field `SystemData` in struct `TrackedResource` info [Changelog] info [Changelog] Total 2 breaking change(s), 217 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-hybridcompute [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface LinuxParameters info [Changelog] - Added Interface Machine info [Changelog] - Added Interface MachineAssessPatchesResult info [Changelog] - Added Interface MachineExtension info [Changelog] - Added Interface MachineExtensionsDeleteHeaders info [Changelog] - Added Interface MachineExtensionsUpdateHeaders info [Changelog] - Added Interface MachineExtensionUpdate info [Changelog] - Added Interface MachineInstallPatchesParameters info [Changelog] - Added Interface MachineInstallPatchesResult info [Changelog] - Added Interface MachinesAssessPatchesHeaders info [Changelog] - Added Interface MachinesAssessPatchesOptionalParams info [Changelog] - Added Interface MachinesInstallPatchesHeaders info [Changelog] - Added Interface MachinesInstallPatchesOptionalParams info [Changelog] - Added Interface MachineUpdate info [Changelog] - Added Interface NetworkInterface info [Changelog] - Added Interface NetworkProfile info [Changelog] - Added Interface NetworkProfileGetOptionalParams info [Changelog] - Added Interface OSProfileLinuxConfiguration info [Changelog] - Added Interface OSProfileWindowsConfiguration info [Changelog] - Added Interface PrivateEndpointConnection info [Changelog] - Added Interface PrivateEndpointConnectionDataModel info [Changelog] - Added Interface PrivateEndpointConnectionsDeleteHeaders info [Changelog] - Added Interface PrivateLinkResource info [Changelog] - Added Interface PrivateLinkScopesDeleteHeaders info [Changelog] - Added Interface ProxyResource info [Changelog] - Added Interface ServiceStatus info [Changelog] - Added Interface ServiceStatuses info [Changelog] - Added Interface Subnet info [Changelog] - Added Interface TrackedResource info [Changelog] - Added Interface WindowsParameters info [Changelog] - Added Type Alias AgentConfigurationMode info [Changelog] - Added Type Alias AgentVersionGetResponse info [Changelog] - Added Type Alias AgentVersionListResponse info [Changelog] - Added Type Alias ArcKindEnum info [Changelog] - Added Type Alias AssessmentModeTypes info [Changelog] - Added Type Alias EsuEligibility info [Changelog] - Added Type Alias EsuKeyState info [Changelog] - Added Type Alias EsuServerType info [Changelog] - Added Type Alias ExtensionMetadataGetResponse info [Changelog] - Added Type Alias ExtensionMetadataListResponse info [Changelog] - Added Type Alias HybridIdentityMetadataGetResponse info [Changelog] - Added Type Alias HybridIdentityMetadataListByMachinesNextResponse info [Changelog] - Added Type Alias HybridIdentityMetadataListByMachinesResponse info [Changelog] - Added Type Alias LastAttemptStatusEnum info [Changelog] - Added Type Alias LicenseAssignmentState info [Changelog] - Added Type Alias LicenseCoreType info [Changelog] - Added Type Alias LicenseEdition info [Changelog] - Added Type Alias LicenseProfilesCreateOrUpdateResponse info [Changelog] - Added Type Alias LicenseProfilesDeleteResponse info [Changelog] - Added Type Alias LicenseProfilesGetResponse info [Changelog] - Added Type Alias LicenseProfilesListNextResponse info [Changelog] - Added Type Alias LicenseProfilesListResponse info [Changelog] - Added Type Alias LicenseProfilesUpdateResponse info [Changelog] - Added Type Alias LicensesCreateOrUpdateResponse info [Changelog] - Added Type Alias LicensesGetResponse info [Changelog] - Added Type Alias LicensesListByResourceGroupNextResponse info [Changelog] - Added Type Alias LicensesListByResourceGroupResponse info [Changelog] - Added Type Alias LicensesListBySubscriptionNextResponse info [Changelog] - Added Type Alias LicensesListBySubscriptionResponse info [Changelog] - Added Type Alias LicenseState info [Changelog] - Added Type Alias LicensesUpdateResponse info [Changelog] - Added Type Alias LicensesValidateLicenseResponse info [Changelog] - Added Type Alias LicenseTarget info [Changelog] - Added Type Alias LicenseType info [Changelog] - Added Type Alias MachinesAssessPatchesResponse info [Changelog] - Added Type Alias MachinesInstallPatchesResponse info [Changelog] - Added Type Alias NetworkProfileGetResponse info [Changelog] - Added Type Alias OsType info [Changelog] - Added Type Alias PatchModeTypes info [Changelog] - Added Type Alias PatchOperationStartedBy info [Changelog] - Added Type Alias PatchOperationStatus info [Changelog] - Added Type Alias PatchServiceUsed info [Changelog] - Added Type Alias ProvisioningState info [Changelog] - Added Type Alias VMGuestPatchClassificationLinux info [Changelog] - Added Type Alias VMGuestPatchClassificationWindows info [Changelog] - Added Type Alias VMGuestPatchRebootSetting info [Changelog] - Added Type Alias VMGuestPatchRebootStatus info [Changelog] - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections info [Changelog] - Interface MachineExtensionProperties has a new optional parameter enableAutomaticUpgrade info [Changelog] - Interface MachinesListByResourceGroupOptionalParams has a new optional parameter expand info [Changelog] - Interface OperationValue has a new optional parameter isDataAction info [Changelog] - Interface OSProfile has a new optional parameter linuxConfiguration info [Changelog] - Interface OSProfile has a new optional parameter windowsConfiguration info [Changelog] - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Added Enum KnownAgentConfigurationMode info [Changelog] - Added Enum KnownArcKindEnum info [Changelog] - Added Enum KnownAssessmentModeTypes info [Changelog] - Added Enum KnownEsuEligibility info [Changelog] - Added Enum KnownEsuKeyState info [Changelog] - Added Enum KnownEsuServerType info [Changelog] - Added Enum KnownLastAttemptStatusEnum info [Changelog] - Added Enum KnownLicenseAssignmentState info [Changelog] - Added Enum KnownLicenseCoreType info [Changelog] - Added Enum KnownLicenseEdition info [Changelog] - Added Enum KnownLicenseState info [Changelog] - Added Enum KnownLicenseTarget info [Changelog] - Added Enum KnownLicenseType info [Changelog] - Added Enum KnownOsType info [Changelog] - Added Enum KnownPatchModeTypes info [Changelog] - Added Enum KnownPatchOperationStartedBy info [Changelog] - Added Enum KnownPatchOperationStatus info [Changelog] - Added Enum KnownPatchServiceUsed info [Changelog] - Added Enum KnownProvisioningState info [Changelog] - Added Enum KnownVMGuestPatchClassificationLinux info [Changelog] - Added Enum KnownVMGuestPatchClassificationWindows info [Changelog] - Added Enum KnownVMGuestPatchRebootSetting info [Changelog] - Added Enum KnownVMGuestPatchRebootStatus info [Changelog] - Added function getContinuationToken info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Class HybridComputeManagementClient has a new signature info [Changelog] - Interface MachineExtensionsListNextOptionalParams no longer has parameter expand info [Changelog] - Type of parameter protectedSettings of interface MachineExtensionProperties is changed from Record<string, unknown> to { info [Changelog] [propertyName: string]: any; info [Changelog] } info [Changelog] - Type of parameter settings of interface MachineExtensionProperties is changed from Record<string, unknown> to { info [Changelog] [propertyName: string]: any; info [Changelog] }
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️hybridcompute [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.hybridcompute.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.hybridcompute.DefaultTag
Generated ApiView
|
This was referenced Sep 12, 2023
Closed
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
dorothyhu
added
WaitForARMFeedback
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
rkmanda
approved these changes
Sep 13, 2023
rkmanda
added
the
Approved-BreakingChange
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Sep 13, 2023
This was referenced Sep 13, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.