Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove en-us from MSDN links #1979

Closed
antkmsft opened this issue Nov 4, 2021 · 0 comments · Fixed by #1989
Closed

Remove en-us from MSDN links #1979

antkmsft opened this issue Nov 4, 2021 · 0 comments · Fixed by #1989
Assignees
@antkmsft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Milestone
[2022] January

Comments

@antkmsft
Copy link
Member

antkmsft commented Nov 4, 2021

In C++ repo, CI even gives us an error if we don't.
Without en-us, the link works perfectly, but opens to everyone in their preferred language.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 4, 2021
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system. labels Nov 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 8, 2021
@RickWinter RickWinter added the MQ This issue is part of a "milestone of quality" initiative. label Nov 8, 2021
@RickWinter RickWinter added this to the [2022] January milestone Nov 8, 2021
@antkmsft antkmsft mentioned this issue Nov 9, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antkmsft antkmsft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

Remove en-us from microsoft links, and fix a couple of dead links
2 participants
@RickWinter @antkmsft