Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of cloud configurations #2180

Closed
1 of 2 tasks
RickWinter opened this issue Apr 30, 2021 · 3 comments
Closed
1 of 2 tasks

Use of cloud configurations #2180

RickWinter opened this issue Apr 30, 2021 · 3 comments
Assignees
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@RickWinter
Copy link
Member

RickWinter commented Apr 30, 2021

Before GA we need to review the endpoint configurations to ensure we are compatible across clouds. We don't need to implement 1550 as long as we are future proofed to do so in 1.1.

Azure/azure-sdk#1550

Tasks:

  • Identify all current cloud endpoint uses (add list to this issue)
  • Verify all instances are customizable by the user
@RickWinter RickWinter added feature-request This issue requires a new behavior in the product in order be resolved. Azure.Core Client This issue points to a problem in the data-plane of the library. labels Apr 30, 2021
@RickWinter RickWinter added this to the [2021] May milestone Apr 30, 2021
@RickWinter RickWinter added the blocking-release Blocks release label Apr 30, 2021
@antkmsft
Copy link
Member

antkmsft commented May 4, 2021

KeyVault KeyClient uses hardcoded "https://vault.azure.net/" scope - could be a problem when using token credential.
In other aspects, it uses vault URL - so should be no problem pointing it to other clouds.

Storage uses StorageScope that is hardcoded to "https://storage.azure.com/" - for TokenCredential this might be problem.
Their credential can parse different endpoint from connection string.
Clients seem to take URLs, so in that way it should be possible to use other clouds (with storage credential, for token credential - I don't think it is currently possible).

So, storage and keyvault might have same problems.
At the same time, they are constructible from URL - so tit is possible for them to detect the cloud that they are being initialized for, and to create BearerTokenAuthenticationPolicy with the correct scope.

So, work likely needs to be done to make them work in national clouds, but it shouldn't be API-breaking, and so can be done post-GA.

More info on the private cloud endpoint URLs: https://docs.microsoft.com/en-us/azure/azure-government/compare-azure-government-global-azure

@antkmsft
Copy link
Member

antkmsft commented May 4, 2021

And other language SDKs have the same public API.

@antkmsft antkmsft closed this as completed May 4, 2021
@antkmsft
Copy link
Member

antkmsft commented May 4, 2021

The thing being proposed for the future, would basically translate to ClientOptions having a parameter for Cloud/WellKnownCloud. I do not think anything blocks us to add that in the future.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants