Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer docs to no longer support VCPKG_ROOT as a mechanism to set/find global versions of the vcpkg repo #4104

Open
ahsonkhan opened this issue Nov 10, 2022 · 0 comments
Labels
EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.

Comments

@ahsonkhan
Copy link
Member

Similar to Azure/azure-sdk-for-c#2404, consider updating AzureVcpkg.cmake to no longer support VCPKG_ROOT as a mechanism to set where the vcpkg registry is located locally.

# AUTO CMAKE_TOOLCHAIN_FILE:
# User can call `cmake -DCMAKE_TOOLCHAIN_FILE="path_to_the_toolchain"` as the most specific scenario.
# An env var VCPKG_ROOT or VCPKG_INSTALLATION_ROOT can be set to let Azure SDK to set the VCPKG toolchain automatically.
# As the last alternative (default case), Azure SDK will automatically clone VCPKG folder and set toolchain from there.
if(NOT DEFINED CMAKE_TOOLCHAIN_FILE)
if(DEFINED ENV{VCPKG_ROOT})
set(CMAKE_TOOLCHAIN_FILE "$ENV{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
CACHE STRING "")
elseif(DEFINED ENV{VCPKG_INSTALLATION_ROOT})
set(CMAKE_TOOLCHAIN_FILE "$ENV{VCPKG_INSTALLATION_ROOT}/scripts/buildsystems/vcpkg.cmake"
CACHE STRING "")
else()
# Set AZURE_SDK_DISABLE_AUTO_VCPKG env var to avoid Azure SDK from cloning and setting VCPKG automatically
# This option delegate package's dependencies installation to user.
if(NOT DEFINED ENV{AZURE_SDK_DISABLE_AUTO_VCPKG})

@ahsonkhan ahsonkhan added EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. labels Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

No branches or pull requests

1 participant