Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] [API Review] Rename CosmosContainer to Container #15813

Closed
ealsur opened this issue Oct 15, 2021 · 0 comments · Fixed by #15823
Closed

[Cosmos] [API Review] Rename CosmosContainer to Container #15813

ealsur opened this issue Oct 15, 2021 · 0 comments · Fixed by #15823
Assignees
Labels

Comments

@ealsur
Copy link
Member

ealsur commented Oct 15, 2021

  1. Rename type CosmosContainer struct to type Container struct
  2. Rename type CosmosContainerProperties struct to type ContainerProperties struct
  3. Rename type CosmosContainerRequestOptions struct to type ContainerRequestOptions struct
  4. Rename type CosmosContainerResponse struct to type ContainerResponse struct

All methods that mention CosmosContainer in their name should be Container, like:

func (c *CosmosClient) GetContainer(databaseId string, containerId string) (*Container, error)

instead of

func (c *CosmosClient) GetCosmosContainer(databaseId string, containerId string) (*CosmosContainer, error)
@ealsur ealsur added the Cosmos label Oct 15, 2021
@ealsur ealsur self-assigned this Oct 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant