Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving go modules to v1+ #17694

Closed
princjef opened this issue Apr 21, 2022 · 5 comments
Closed

Moving go modules to v1+ #17694

princjef opened this issue Apr 21, 2022 · 5 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@princjef
Copy link
Member

Feature Request

Is there any plan as part of #14387 to move the inner packages to v1+ versions? We make use of multiple packages in this repo both directly and indirectly that have had multiple breaking releases on their v0.x releases. Any time we have to update one of them it creates immense pain because we have to try to find or force the various dependencies in our system to use the exact same major version of the underlying packages. This is difficult enough to test and verify when we control the dependencies but even more painful when they are subdependencies of other packages we use.

The semantic path versioning of major versions of go modules is built specifically to make this a non-issue by allowing multiple major versions to be used in the same project. However, that benefit only applies once a module has moved past v0.x versioning, which isn't the case for anything that we currently use within this repo. Is there any plan/roadmap for doing this? It would be a huge operational/maintenance benefit going forward.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 21, 2022
@RickWinter RickWinter added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Docs Client This issue points to a problem in the data-plane of the library. Azure.Core labels Apr 21, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 21, 2022
@jhendrixMSFT
Copy link
Member

The modules under the /sdk directory will indeed go to v1.0.0 and follow semver rules once they're out of beta status. I can't comment on when this will happen and will defer to others.

@jhendrixMSFT
Copy link
Member

Our modules have hit v1.0.0 and will follow SemVer rules going forward.

@jhendrixMSFT jhendrixMSFT added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label May 25, 2022
@ghost
Copy link

ghost commented May 25, 2022

Hi @princjef. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

1 similar comment
@ghost
Copy link

ghost commented May 25, 2022

Hi @princjef. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@princjef
Copy link
Member Author

princjef commented Jun 1, 2022

Thanks!

@princjef princjef closed this as completed Jun 1, 2022
@RickWinter RickWinter added this to the [2022] June milestone Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

5 participants