Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multi Tenant Auth with DAC - Workload Identity #21053

Closed
g2vinay opened this issue Jun 23, 2023 · 0 comments · Fixed by #21123
Closed

Support Multi Tenant Auth with DAC - Workload Identity #21053

g2vinay opened this issue Jun 23, 2023 · 0 comments · Fixed by #21123
Assignees
@chlowell
Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Milestone
2023-07

Comments

@g2vinay
Copy link
Member

g2vinay commented Jun 23, 2023

Currently, DAC reads in tenant ID for Workload Identity from env only, it needs to honour the tenant ID supplied in code options to support multi tenant auth.

image

The code that needs to be updated to support tenant ID from code options:
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/default_azure_credential.go#L87C45-L87C78
@g2vinay g2vinay added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jun 23, 2023
@g2vinay g2vinay added this to the 2023-07 milestone Jun 23, 2023
@joshfree joshfree added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jun 23, 2023
@chlowell chlowell mentioned this issue Jul 10, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-07
Development

Successfully merging a pull request may close this issue.

DefaultAzureCredential TenantID applies to workload identity chlowell/azure-sdk-for-go
3 participants
@joshfree @g2vinay @chlowell