Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azopenai] Model renames #21106

Closed
richardpark-msft opened this issue Jul 6, 2023 · 2 comments
Closed

[azopenai] Model renames #21106

richardpark-msft opened this issue Jul 6, 2023 · 2 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. OpenAI

Comments

@richardpark-msft
Copy link
Member

We have a few models that come from OpenAI that don't match our conventions in Azure. This is renaming/rearranging will affect all of the SDKs, so it's probably post beta.2.

A new nits here (can be fixed later).
ImageGenerationOptions needs a better name, maybe something like ImageGenerationSettings (or perhaps CreateImageSettings so it aligns with CreateImageOptions).
And ideally, it would contain all required settings and the optional ones moved to CreateImageOptions.

Originally posted by @jhendrixMSFT in #21054 (comment)

@richardpark-msft richardpark-msft self-assigned this Jul 6, 2023
@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. OpenAI labels Jul 6, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 6, 2023
@jhendrixMSFT
Copy link
Member

Thinking more, our typical pattern is that all required params are discrete and only the optional ones are grouped.

@jhendrixMSFT jhendrixMSFT removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 6, 2023
@RickWinter RickWinter added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jul 25, 2023
@richardpark-msft
Copy link
Member Author

Leaving this as-is for now, we're trying to do less changes from the default client at this point.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Development

No branches or pull requests

3 participants