Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcosmos forces min go version to 1.22.0 instead of 1.18 #22827

Closed
berndverst opened this issue May 2, 2024 · 6 comments · Fixed by #22829
Closed

azcosmos forces min go version to 1.22.0 instead of 1.18 #22827

berndverst opened this issue May 2, 2024 · 6 comments · Fixed by #22829
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@berndverst
Copy link
Member

Bug Report

azcosmos v1.0.0 forces the min Go version to 1.22.0 instead of the standard 1.18 used by the rest of the Azure SDK for Go.

This was caused in #22394 by @simorenoh.

Please release a patch version v1.0.1 with the go.mod set to 1.18 again.
@berndverst
Copy link
Member Author

cc @jhendrixMSFT @ealsur

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @MehaKaushik @wmengmsft.

@berndverst
Copy link
Member Author

For my own needs Go 1.21 would be ok too -- I'm trying to Backport this to Dapr 1.12 (which we still have to support), but Dapr 1.12 has to stick with Go 1.21

@jhendrixMSFT
Copy link
Member

I thought the POR was to set this to 1.21 due to requiring a new feature in Go 1.21. We must support N and N-1 versions at minimum.

@berndverst
Copy link
Member Author 

go mod tidy -go=1.21
go: github.com/Azure/azure-sdk-for-go/sdk/data/azcosmos@v1.0.0 requires go@1.22.0, but 1.21 is requested

@jhendrixMSFT jhendrixMSFT removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels May 2, 2024
@github-actions github-actions bot added the needs-team-triage Workflow: This issue needs the team to triage. label May 2, 2024
@jhendrixMSFT jhendrixMSFT removed the needs-team-triage Workflow: This issue needs the team to triage. label May 2, 2024
@ealsur ealsur mentioned this issue May 2, 2024
Merged
@ealsur
Copy link
Member

ealsur commented May 2, 2024

Release on https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fdata%2Fazcosmos%2Fv1.0.1

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

azcosmos - downgrade to go 1.21
3 participants
@ealsur @berndverst @jhendrixMSFT