Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Invitation API request #4086

Closed
daniel-simpson opened this issue Feb 14, 2019 · 9 comments
Closed

Create Invitation API request #4086

daniel-simpson opened this issue Feb 14, 2019 · 9 comments
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.

Comments

@daniel-simpson
Copy link

Service Package Request

Very interested in support for the MS Graph API invitations endpoint. My apologies if I'm missing an existing implementation, but I'm unable to see any reference to this API within the source of this repo.

I would like to be able to use this invitation endpoint (along with the already implemented GetUser and DeleteUser endpoints) to enhance the terraform AzureAD provider as per this Pull Request

Any assistance would be greatly appreciated. If need be I'm happy to have a hand in implementing, but I'm still quite new to Go and wasn't able to figure out the codegen process.

Thank you!

@jhendrixMSFT
Copy link
Member

@joshgav I don't see a swagger for this API, can you please contact the endpoint owner to see if they have a plan for creating one?

@dansanabria
Copy link

Did you ever get a reply from the endpoint owner @daniel-simpson ?

@daniel-simpson
Copy link
Author

@dansanabria unfortunately not, and as I was only doing investigation at that point we ended up having to park this piece of work :(

@mwieczorek
Copy link

@jhendrixMSFT I'd like to get this in the sdk too.
You suggested to contact the endpoint owner - how can I do that? I mean: how can I find the endpoint owner?

@jhendrixMSFT
Copy link
Member

@maggiepint do you know who to follow up with about this?

@ArcturusZhang ArcturusZhang added feature-request This issue requires a new behavior in the product in order be resolved. and removed Feature Request labels Apr 27, 2020
@Maarc-D
Copy link

Maarc-D commented Jul 20, 2020

Hello,

Same need, I've try to find out where adding config file to let autorest make the job of the services folder like said in https://github.com/Azure/azure-sdk-for-go/blob/master/CONTRIBUTING.md
I tried to start implementation on : https://github.com/Maarc-D/azure-sdk-for-go/tree/feat/graph-api-1.0 Because it's really needed on our side
But I can't find out where a stored the configfiles for autorest

Someone can tell me what I missed plz ?

like @daniel-simpson the aim is to create the autorest config matching microsoft api graph : https://docs.microsoft.com/en-us/graph/api/overview?view=graph-rest-1.0

Regards Marc.

@Maarc-D
Copy link

Maarc-D commented Aug 14, 2020

Hello,

Does someone know if I need to staticly put the go code generated by the swagger I created : Azure/azure-rest-api-specs#10275

or does it will be automatic once merged ?

because I've test all the stack using the generated go files to code the missing feature on terraform provider : hashicorp/terraform-provider-azuread#297

it's working fine

maybe @jhendrixMSFT @dansanabria

Regards Marc.

@ArcturusZhang
Copy link
Member

Hi @Maarc-D once this swagger PR is merged, you could just open a new issue using the feature-request template, and then I will handle the release process.

But I am curious that would they approve a new swagger authored by outside of the service team?

@azure-sdk azure-sdk added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 24, 2020
@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@RickWinter RickWinter added Mgmt This issue is related to a management-plane library. and removed specs labels Jul 12, 2021
@lirenhe
Copy link
Member

lirenhe commented Sep 14, 2021

We don't have microsoft.graph in https://github.com/Azure/azure-rest-api-specs/. The openAPI specs are maintained by MicrosoftGraph team in a separate repo https://github.com/microsoftgraph/msgraph-metadata. The GO SDK would not use the openapi specs in that repo. So if you still have this request, please contact msgraph team directly. Thanks

@lirenhe lirenhe closed this as completed Sep 14, 2021
@RickWinter RickWinter modified the milestones: Backlog, [2021] October Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

9 participants