Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Account CustomDomain has the wrong type #4473

Closed
drosseau opened this issue Apr 3, 2019 · 4 comments
Closed

Storage Account CustomDomain has the wrong type #4473

drosseau opened this issue Apr 3, 2019 · 4 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.

Comments

@drosseau
Copy link

drosseau commented Apr 3, 2019

Bug Report

github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2018-11-01/storage

  • What happened?

The JSON and Go type don't match up for CustomDomains. The Go type is *bool, but the JSON contains a string.

  • What did you expect or want to happen?

Types match.

  • How can we reproduce it?

Create a storage account with a custom domain and use the AccountsClient to list storage accounts.

  • Anything we should know about your environment.

Normal. Go version 1.12.1

@jhendrixMSFT jhendrixMSFT added customer-reported Issues that are reported by GitHub users external to the Azure organization. specs labels May 22, 2019
@jhendrixMSFT
Copy link
Member

Hello! If you have an easy repro could you please provide the JSON response body of the failed request? You can use the built in logging facility to log request/response bodies to get this info. Thanks!

@jhendrixMSFT
Copy link
Member

@drosseau according to the RP this should be resolved, now when you call the API the value for useSubDomainName is no longer sent across the wire. Can you confirm it works for you now?

@drosseau
Copy link
Author

drosseau commented Jun 6, 2019

Yep, I don't see useSubDomain anymore.

@jhendrixMSFT
Copy link
Member

Closing as this is now resolved, thanks for helping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

No branches or pull requests

2 participants