Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the Service Bus SDK #593

Closed
tombuildsstuff opened this issue Apr 19, 2017 · 4 comments
Closed

Regenerate the Service Bus SDK #593

tombuildsstuff opened this issue Apr 19, 2017 · 4 comments
Assignees
Milestone

Comments

@tombuildsstuff
Copy link
Contributor

👋 hey Azure SDK for Go team!

I've been going through trying to upgrade us to v9 of the SDK - and noticed a blocker 😞

When previously dry-running the SDK upgrade - I'd commented out a breaking change in the Service Bus SDK, where the Location field has been removed from the Response models. Unfortunately this meant that I'd only reported 1 of the 2 issues with the Service Bus SDK, which means we're currently unable to upgrade to v9 of the Azure SDK for Go 😞

I was hoping that we may be able to work around this by not posting the Location field at Creation/Update time - but unfortunately it's a required field. I've opened a PR to the Rest API Specs Repository which fixes this - once this is merged, would it be possible to re-generate and re-release the SDK?

Could we also add this to the list of breaking changes in v9 too until this is resolved?

Thanks!

@marstr marstr self-assigned this Apr 20, 2017
@marstr
Copy link
Member

marstr commented Apr 20, 2017

Thanks for taking care of submitting a PR the API Specs Repo! Given that this is strictly additive to what exists in v9, we may as well add it in as a v9.1.0. We're going to turn our sights to v10 shortly, but given how useful it would be to v9 to have this added back in, we'll try to include it in both.

@marstr marstr added this to the v9.1.0 milestone Apr 20, 2017
@stack72
Copy link

stack72 commented Apr 26, 2017

Hi @marstr

Is there any ETA on 9.1? We are currently waiting on it to support web_apps in terraform

Thanks

Paul

@tombuildsstuff
Copy link
Contributor Author

@marstr I'm not sure if it's helpful or going to cause a ton of pain with the v10 release - but I had some spare time tonight and ended up attempting this in #601 :)

@mcardosos
Copy link
Contributor

Fixed!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants