Fix tests in Face SDK (#45865)

Author: alzimmermsft

sdk/face/azure-ai-vision-face/pom.xml

@@ -49,6 +49,11 @@
     <checkstyle.suppressionsLocation>checkstyle-suppressions.xml</checkstyle.suppressionsLocation>
     <spotbugs.skip>false</spotbugs.skip>
     <spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
+
+    <javaModulesSurefireArgLine>
+      --add-exports com.azure.ai.vision.face/com.azure.ai.vision.face.tests.utils=ALL-UNNAMED
+      --add-exports com.azure.ai.vision.face/com.azure.ai.vision.face.tests.utils.http=ALL-UNNAMED
+    </javaModulesSurefireArgLine>
   </properties>
   <dependencies>
     <dependency>
@@ -69,7 +74,7 @@
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-core-test</artifactId>
-      <version>1.27.0-beta.9</version> <!-- {x-version-update;com.azure:azure-core-test;dependency} -->
+      <version>1.27.0-beta.10</version> <!-- {x-version-update;unreleased_com.azure:azure-core-test;dependency} -->
       <scope>test</scope>
     </dependency>
     <dependency>

sdk/face/azure-ai-vision-face/src/test/java/com/azure/ai/vision/face/tests/DetectionTest.java

@@ -12,11 +12,11 @@
 import com.azure.ai.vision.face.samples.utils.Resources;
 import com.azure.ai.vision.face.tests.commands.detection.DetectSyncFunction;
 import com.azure.ai.vision.face.tests.commands.detection.DetectionFunctionProvider;
-import com.azure.ai.vision.face.tests.utils.FaceDisplayNameGenerator;
 import com.azure.ai.vision.face.tests.utils.TestUtils;
 import com.azure.core.test.annotation.RecordWithoutRequestBody;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.DisplayNameGeneration;
+import org.junit.jupiter.api.DisplayNameGenerator;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
@@ -27,7 +27,7 @@
 import java.util.function.Supplier;
 import java.util.stream.Stream;
 
-@DisplayNameGeneration(FaceDisplayNameGenerator.class)
+@DisplayNameGeneration(DisplayNameGenerator.Standard.class)
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 @RecordWithoutRequestBody
 public class DetectionTest extends FaceClientTestBase {
@@ -46,7 +46,7 @@ public void testDetectFaceReturnFaceIdAndReturnRecognitionModel(String httpClien
 
         Assertions.assertNotNull(detectResults);
 
-        Assertions.assertEquals(detectResults.size(), 1);
+        Assertions.assertEquals(1, detectResults.size());
         FaceDetectionResult result = detectResults.get(0);
 
         Assertions.assertEquals(returnFaceId, result.getFaceId() != null);

sdk/face/azure-ai-vision-face/src/test/java/com/azure/ai/vision/face/tests/LivenessSessionTest.java

@@ -12,12 +12,12 @@
 import com.azure.ai.vision.face.models.LivenessSession;
 import com.azure.ai.vision.face.tests.commands.liveness.ILivenessSessionSyncCommands;
 import com.azure.ai.vision.face.tests.commands.liveness.LivenessSessionCommandsProvider;
-import com.azure.ai.vision.face.tests.utils.FaceDisplayNameGenerator;
 import com.azure.ai.vision.face.tests.utils.TestUtils;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayNameGeneration;
+import org.junit.jupiter.api.DisplayNameGenerator;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
@@ -28,7 +28,7 @@
 import java.util.function.Supplier;
 import java.util.stream.Stream;
 
-@DisplayNameGeneration(FaceDisplayNameGenerator.class)
+@DisplayNameGeneration(DisplayNameGenerator.Standard.class)
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 public class LivenessSessionTest extends FaceClientTestBase {
     private ILivenessSessionSyncCommands mCurrentCommand;
@@ -68,7 +68,7 @@ public void testCreateSessionWithTokenTTL(String httpClientName, FaceServiceVers
         CreateLivenessSessionResult result = createSessionAndVerify(livenessCommands, content);
         LivenessSession livenessSession = livenessCommands.getLivenessSessionResultSync(result.getSessionId());
         Assertions.assertNotNull(livenessSession);
-        Assertions.assertEquals(livenessSession.getAuthTokenTimeToLiveInSeconds(), authTokenTimeToLiveInSeconds);
+        Assertions.assertEquals(authTokenTimeToLiveInSeconds, livenessSession.getAuthTokenTimeToLiveInSeconds());
     }
 
     @BeforeEach

sdk/face/azure-ai-vision-face/src/test/java/com/azure/ai/vision/face/tests/LivenessSessionWithVerifyTest.java

@@ -15,14 +15,14 @@
 import com.azure.ai.vision.face.samples.utils.Utils;
 import com.azure.ai.vision.face.tests.commands.liveness.ILivenessWithVerifySessionSyncCommands;
 import com.azure.ai.vision.face.tests.commands.liveness.LivenessSessionWithVerifyCommandsProvider;
-import com.azure.ai.vision.face.tests.utils.FaceDisplayNameGenerator;
 import com.azure.ai.vision.face.tests.utils.TestUtils;
 import com.azure.core.test.annotation.RecordWithoutRequestBody;
 import com.azure.core.util.BinaryData;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayNameGeneration;
+import org.junit.jupiter.api.DisplayNameGenerator;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
@@ -33,7 +33,7 @@
 import java.util.function.Supplier;
 import java.util.stream.Stream;
 
-@DisplayNameGeneration(FaceDisplayNameGenerator.class)
+@DisplayNameGeneration(DisplayNameGenerator.Standard.class)
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 @RecordWithoutRequestBody
 public class LivenessSessionWithVerifyTest extends FaceClientTestBase {
@@ -77,7 +77,7 @@ public void testCreateSessionWithTokenTTL(String httpClientName, FaceServiceVers
         LivenessWithVerifySession livenessSession
             = livenessCommands.getLivenessWithVerifySessionResultSync(result.getSessionId());
         Assertions.assertNotNull(livenessSession);
-        Assertions.assertEquals(livenessSession.getAuthTokenTimeToLiveInSeconds(), authTokenTimeToLiveInSeconds);
+        Assertions.assertEquals(authTokenTimeToLiveInSeconds, livenessSession.getAuthTokenTimeToLiveInSeconds());
     }
 
     @BeforeEach

sdk/face/azure-ai-vision-face/src/test/java/com/azure/ai/vision/face/tests/utils/FaceDisplayNameGenerator.java

@@ -4,16 +4,13 @@
 package com.azure.ai.vision.face.tests.utils;
 
 import com.azure.ai.vision.face.FaceServiceVersion;
-import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import reactor.util.function.Tuple3;
 
 import java.util.Arrays;
 import java.util.stream.Stream;
 
 public class TestUtils {
-    public static final String DISPLAY_NAME_WITH_ARGUMENTS
-        = "[" + ParameterizedTest.INDEX_PLACEHOLDER + "] " + ParameterizedTest.ARGUMENTS_WITH_NAMES_PLACEHOLDER;
 
     public static final String EMPTY_UUID = "00000000-0000-0000-0000-000000000000";
     public static final String FAKE_TOKEN = "FAKE_TOKEN";