Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure KeyVault-Secret Samples issue #12431

Closed
Melanie-Ma opened this issue Jun 23, 2020 · 1 comment
Closed

Azure KeyVault-Secret Samples issue #12431

Melanie-Ma opened this issue Jun 23, 2020 · 1 comment
Assignees
@vcolin7
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Melanie-Ma
Copy link
Contributor

Melanie-Ma commented Jun 23, 2020 •
edited
Loading

Section Link:
image

Reason: The method SecretClient() is an internal constructor in the package of keyvault-secrets.

Suggestion: Delete the method getSecretClient() and change the name of the method getSyncSecretClientCodeSnippets to getSecretClient() . If creating a new SecretClient , we suggest that using the method SecretClientBuilder() to create the client.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 23, 2020
@Melanie-Ma
Copy link
Contributor Author

@jongio , for notification.

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 23, 2020
@loarabia loarabia added the Client This issue points to a problem in the data-plane of the library. label Jun 26, 2020
@lilyjma lilyjma removed the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 30, 2020
@Melanie-Ma Melanie-Ma changed the title Azure Core Samples issue Azure KeyVault-Secret Samples issue Jul 3, 2020
@vcolin7 vcolin7 self-assigned this Jul 7, 2020
@vcolin7 vcolin7 mentioned this issue Jul 7, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vcolin7 vcolin7

Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@loarabia @vcolin7 @lilyjma @alzimmermsft @Melanie-Ma