Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test lroTimeout #12786

Closed
alzimmermsft opened this issue Jul 2, 2020 · 6 comments · Fixed by #12793
Closed

Flaky Test lroTimeout #12786

alzimmermsft opened this issue Jul 2, 2020 · 6 comments · Fixed by #12793
Assignees
Labels
Azure.Core azure-core Mgmt This issue is related to a management-plane library.

Comments

@alzimmermsft
Copy link
Member

alzimmermsft commented Jul 2, 2020

Azure Core Management has a test LROPollerTests.lroTimeout which sporadically fails. This forces pipelines to re-run.

org.opentest4j.AssertionFailedError: expected: <5> but was: <6>
	at com.azure.core.management@1.0.0-beta.2/com.azure.core.management.implementation.polling.LROPollerTests.lroTimeout(LROPollerTests.java:477)

org.opentest4j.AssertionFailedError: expected: <4> but was: <5>
	at com.azure.core.management@1.0.0-beta.2/com.azure.core.management.implementation.polling.LROPollerTests.lroTimeout(LROPollerTests.java:477)
@alzimmermsft alzimmermsft added Mgmt This issue is related to a management-plane library. Azure.Core azure-core labels Jul 2, 2020
@JimSuplizio
Copy link
Member

@ChenTanyi
This is something that needs to be fixed sooner rather than later. Today it was impacting releases. Also, the CODEOWNERS really needs to be updated.

@ChenTanyi
Copy link
Contributor

@JimSuplizio I'll see the test right now. @weidongxu-microsoft Please also take a look at it for the test.

@ChenTanyi
Copy link
Contributor

@alzimmermsft @JimSuplizio Could you show how you run the test? I have reinstalled and tested it in IntelliJ with success (Java 11).
image

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jul 3, 2020

That assertion had a bit dependency on timing within the test, I will disable it. #12793

@alzimmermsft @JimSuplizio Let me know if I continue to merge the disable PR, or else.

@ChenTanyi
Copy link
Contributor

@alzimmermsft Will it be able to continue release the azure-core-management? Thanks! (I saw the other PR of azure-core version bump, not sure it matter the core-management release or not)

@alzimmermsft
Copy link
Member Author

@ChenTanyi azure-core-management will continue to be able to be released. These type of issues just make releasing a little more difficult as pipelines need to pass and random test failures will force re-runs, just making it more time consuming.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core azure-core Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants