Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review for Spring modules #20281

Closed
saragluna opened this issue Mar 31, 2021 · 3 comments
Closed

API review for Spring modules #20281

saragluna opened this issue Mar 31, 2021 · 3 comments
Assignees
@stliu @saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Spring Cloud Azur...

Comments

@saragluna
Copy link
Member

The sdk APIs will get reviewed on https://apiview.dev/ and one example is https://apiview.dev/Assemblies/Review/4a20c92e936b41b4913844900fd3962e. For all Spring modules, it would be better if the partner SDK teams could review our APIs in the same way. This issue is to track API reviewing for Spring modules:

  • We should see if the Spring team can leverage the apiview so we can ensure our public surface area aligns with Track 2 guidelines
  • There're some differences between the SDK and its Spring Integration. The SDK exports all sorts of APIs; however, Spring uses the SDK APIs and implements some Spring frameworks' APIs at the same time.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 31, 2021
@saragluna saragluna added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Mar 31, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 31, 2021
@saragluna saragluna added this to the Backlog milestone Mar 31, 2021
@yiliuTo yiliuTo added the feature-request This issue requires a new behavior in the product in order be resolved. label Mar 31, 2021
@srnagar
Copy link
Member

srnagar commented Apr 2, 2021

@saragluna - Thanks for filing this issue. If you have any questions regarding the API view, please reach out to @praveenkuttappan.

@saragluna
Copy link
Member Author

Thanks @srnagar for the update. @praveenkuttappan, do we have an instruction doc for how to integrate with apiview?

@chenrujun chenrujun assigned stliu, seanli1988 and saragluna and unassigned stliu and seanli1988 Apr 6, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@saragluna saragluna moved this from Todo to In Progress in Spring Cloud Azure Jan 6, 2022
@saragluna
Copy link
Member Author

saragluna commented Jan 6, 2022 •
edited
Loading

Closing in favor of #24356.

Repository owner moved this from In Progress to Done in Spring Cloud Azure Jan 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stliu stliu

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta4
Development

No branches or pull requests
5 participants
@stliu @seanli1988 @saragluna @srnagar @yiliuTo