Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tracing is broken for EventHub binder #23035

Closed
3 tasks done
lmolkova opened this issue Jul 16, 2021 · 2 comments
Closed
3 tasks done

[BUG] Tracing is broken for EventHub binder #23035

lmolkova opened this issue Jul 16, 2021 · 2 comments
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. OpenTelemetry OpenTelemetry instrumentation
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Jul 16, 2021

Describe the bug
Following the eventhub binder app doc with tracing enabled: message span is not correlated to incoming request.

This is a reactor context propagation issue and we'd need to find

  • way to manually pass context (if possible)
  • make magical propagation work

This issue is mostly created for investigation purposes.

It does not affect non-binder scenario (e.g. this one)

To Reproduce

  1. create sample app
  2. add application insights agent and configure azure sdk tracing
  3. send/receive/process message
  4. check message span - it is not correlated to the incoming request

Expected behavior
message span is created as a child of incoming request.

Screenshots

Actual: Two traces (with 2 trace-ids)

image

image

Expected: 1 trace (created without binder)

image

Setup (please complete the following information):

  • OS: windows
  • IDE: IntelliJ
  • Library/Libraries: com.azure:azure-core:1.17.0, com.azure:azure-core:1.17.0, com.azure:azure-core-tracing-opentelemetry:1.0.0-beta12, com.azure.spring:azure-spring-cloud-stream-binder-eventhubs:2.5.0, applicationinsights-agent-3.1.1

Additional context
Context is available when sending messages to supply sink

image

But lost when a message is instrumented

image

Stacktrace shows the attempt of otel agent to propagate reactor context, but it's not successful.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 16, 2021
@lmolkova lmolkova self-assigned this Jul 16, 2021
@lmolkova lmolkova added azure-spring-eventhubs Spring event hubs related issues. Client This issue points to a problem in the data-plane of the library. labels Jul 16, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 16, 2021
@yiliuTo yiliuTo added azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Aug 17, 2021
@yiliuTo yiliuTo added this to the Backlog milestone Aug 17, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@lmolkova lmolkova added the OpenTelemetry OpenTelemetry instrumentation label Jun 16, 2022
@stliu
Copy link
Member

stliu commented Aug 16, 2022

@lmolkova Hi is this still valid?

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Oct 9, 2022
@ghost
Copy link

ghost commented Oct 9, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Oct 24, 2022
Repository owner moved this from Todo to Done in Spring Cloud Azure Oct 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. OpenTelemetry OpenTelemetry instrumentation
Projects
Archived in project
Development

No branches or pull requests

3 participants