Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Enable/disable azure-spring-boot auto configurations based on properties #23367

Closed
Tracked by #23421
, #23402
...
rvvaeke opened this issue Aug 5, 2021 · 3 comments · Fixed by #23849
Closed
Tracked by #23421
, #23402
...

[FEATURE REQ] Enable/disable azure-spring-boot auto configurations based on properties #23367

rvvaeke opened this issue Aug 5, 2021 · 3 comments · Fixed by #23849
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] November

Comments

@rvvaeke
Copy link

rvvaeke commented Aug 5, 2021

Is your feature request related to a problem? Please describe.
There is currently no flexibility in when the *AutoConfiguration classes in azure-spring-boot are applied. In some scenarios it is feasible to disable certain *AutConfiguration classes. This would provide flexibility in configuring different Spring context, especially in tests.

Describe the solution you'd like
Support enabling/disabling of *AutoConfiguration classes in azure-spring-boot using properties. For example: azure.storage.enabled or azure.cosmos.enabled.

Describe alternatives you've considered
None.

Additional context
None.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 5, 2021
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Aug 5, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 5, 2021
@backwind1233 backwind1233 added this to the Backlog milestone Aug 5, 2021
@backwind1233
Copy link
Contributor

@rvvaeke Thanks for your advice, we have added it to our backlog and will discuss about it. We will inform you if there is any updates.

@stliu stliu assigned saragluna and unassigned backwind1233 Aug 9, 2021
@stliu stliu added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 9, 2021
@stliu stliu modified the milestones: Backlog, [2021] September Aug 9, 2021
@saragluna saragluna added the Client This issue points to a problem in the data-plane of the library. label Aug 9, 2021
@saragluna saragluna mentioned this issue Aug 9, 2021
Closed
2 tasks
@saragluna saragluna linked a pull request Aug 31, 2021 that will close this issue
Add Spring Boot auto-configuration of all Azure Spring supported SDK clients #23849
Merged
10 tasks
@saragluna
Copy link
Member

This has been merged to the feature/azure-spring-cloud-4.0 branch. #23849

@saragluna saragluna reopened this Sep 17, 2021
@stliu stliu mentioned this issue Sep 30, 2021
Closed
@saragluna
Copy link
Member

Closing this issue now, please check #24260 for the release of our next major version.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] November
4 participants
@stliu @backwind1233 @saragluna @rvvaeke