Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring.aad.webapi breaking change in 3.7.0 #23453

Closed
3 tasks done
spoptchev-extern opened this issue Aug 10, 2021 · 7 comments
Closed
3 tasks done

spring.aad.webapi breaking change in 3.7.0 #23453

spoptchev-extern opened this issue Aug 10, 2021 · 7 comments
Assignees
@stliu @chenrujun
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. breaking-change bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. compat breaks customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Milestone
[2021] September

Comments

@spoptchev-extern
Copy link

Describe the bug
As we tried to update com.azure.spring:azure-spring-boot-starter-active-directory from 3.4.0 to 3.7.0 we did not expect any breaking changes on the API but there were several. This is especially unexpected when you use a custom configuration.

e.g.: com.azure.spring.aad.webapi.AADResourceServerClientConfiguration was removed.

To Reproduce
Upgrade from version 3.4.0 to 3.7.0.

Expected behavior
Follow semantic versioning where a minor version change does not cause a breaking change.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 10, 2021
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. labels Aug 10, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 10, 2021
@joshfree
Copy link
Member

@stliu can you please follow up on this?

@JonathanGiles was this missed in apiview? @benbp @kurtzeborn are there extra gates we could add to catch this in the build pipeline?

@benbp
Copy link
Member

benbp commented Aug 10, 2021 •
edited
Loading

@praveenkuttappan @weshaggard @hallipr

@joshfree joshfree changed the title [BUG] Versions do not follow SemVer spring.aad.webapi breaking change in 3.7.0 Aug 10, 2021
@JonathanGiles
Copy link
Member

As far as I can see, this is not on APIView. I'm not sure how this was released - something @stliu can chase up. I would expect that going forward these will go through the standard APIView review process too.

@chenrujun chenrujun self-assigned this Aug 11, 2021
@chenrujun chenrujun mentioned this issue Aug 11, 2021
Closed
4 tasks
@stliu stliu added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 11, 2021
@stliu
Copy link
Member

stliu commented Aug 11, 2021

@JonathanGiles I totally agree, @chenrujun is working on it, to have all our release go through the standard api review process

@chenrujun
Copy link

Hi, @spoptchev-extern .

Thanks for reaching out.
It's our mistake to have breaking change.
We are trying to avoid breaking change by some tool in the following release versions.

If you want to find com.azure.spring.aad.webapi.AADResourceServerClientConfiguration in 3.4.0, please use com.azure.spring.aad.AADOAuth2ClientConfiguration in 3.7.0 instead.

Sorry to cause you trouble.

@stliu stliu added this to the [2021] September milestone Aug 11, 2021
@spoptchev-extern
Copy link
Author

No problem, thank you for improving the process.

@chenrujun
Copy link

Closing this issue. Use #23471 to track this problem.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stliu stliu

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. breaking-change bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. compat breaks customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
6 participants
@stliu @benbp @joshfree @JonathanGiles @chenrujun @spoptchev-extern