[BUG] - Proxy authentication not set correctly in ServiceBusClientBuilder

[ram-itzme]

Describe the bug
When service bus client is created from the apps behind corporate proxy, the proxy authentication fails because the authentication type always defaults to NONE.

This results in the client connection failure

Exception or Stack Trace
2021-09-21 21:04:17.499 ERROR 4464 --- [ctor-executor-1] c.m.a.p.transport.proxy.impl.ProxyImpl : Proxy authentication required. User configured: 'NONE', but supported proxy authentication methods are: BASIC

To Reproduce
Configure HTTP_PROXY, HTTPS_PROXY, PROXY_USERNAME, PROXY_PASSWORD variables as environment variables.

Create service bus configuration using below sample config

spring:
  cloud:
    function:
      definition: Sampleprocessor
    stream:
      bindings:
        SampleProcessor-in-0:
          destination: input.2
          group: corp-proxy-group
        SampleProcessor-out-0:
          destination: topic-1
    azure:
      servicebus:
        connection-string: Endpoint= <<Azure service bus connection string>>
        transport-type: amqp_web_sockets

Run the application

Code Snippet from ServiceBusClientBuilder.java

    private ProxyOptions getDefaultProxyConfiguration(Configuration configuration) {
        ProxyAuthenticationType authentication = ProxyAuthenticationType.NONE;
The above code sets default authentication to NONE, however, in the downstream, this is never reset if proxy credentials are configured as below.

  private ProxyOptions getProxyOptions(ProxyAuthenticationType authentication, String proxyAddress) {
        String host;
        int port;
        if (HOST_PORT_PATTERN.matcher(proxyAddress.trim()).find()) {
            final String[] hostPort = proxyAddress.split(":");
            host = hostPort[0];
            port = Integer.parseInt(hostPort[1]);
            final Proxy proxy = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(host, port));
            final String username = configuration.get(ProxyOptions.PROXY_USERNAME);
            final String password = configuration.get(ProxyOptions.PROXY_PASSWORD);
            return new ProxyOptions(authentication, proxy, username, password);
        } else {
            com.azure.core.http.ProxyOptions coreProxyOptions = com.azure.core.http.ProxyOptions
                .fromConfiguration(configuration);
            return new ProxyOptions(authentication, new Proxy(coreProxyOptions.getType().toProxyType(),
                coreProxyOptions.getAddress()), coreProxyOptions.getUsername(), coreProxyOptions.getPassword());
        }
    }

Expected behavior
The authentication type is chosen based on the environment varaibles. and not defaulted to NONE.

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (please complete the following information):

• OS: Windows 10
• IDE: IntelliJ
• Library/Libraries: azure-messaging-servicebus 7.4.1
• Java version: openjdk11
• App Server/Environment: tomcat
• Frameworks: Spring Boot

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please provide

• verbose dependency tree (mvn dependency:tree -Dverbose)

Additional context
Add any other context about the problem here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

• Bug Description Added
• Repro Steps Added
• Setup information Added

[joshfree]

@alzimmermsft could you please follow up with @ram-itzme on Proxy authentication?

[alzimmermsft]

Re-assigning to @ki1729 as this uses the AMQP style proxy and not the Core style proxy.

[saragluna]

@ram-itzme I noticed that you pasted configurations of a spring cloud stream binder, were you using the azure-messaging-servicebus directly or the azure-spring-cloud-stream-binder-servicebus-xxx library?

[ram-itzme]

@saragluna I am using the azure-messaging-servicebus library.

[ram-itzme]

@saragluna Do you need any additional details from me to look into this issue ?

[saragluna]

@ram-itzme sorry for the late response; it was our National Day holiday. No more details from my side, but since you're using the SDK instead of the Spring library, I think @ki1729 could help you with this issue.

[ki1729]

@ram-itzme Thanks for bringing this up! You are right, Authentication type is never picked up when proxyOptions are loaded from the configuration. As a temproray workaround, you can set the proxyOptions in ServiceBusClientBuilder with the correct authentication type, credentials and address, and that should be picked up correctly.

[ki1729]

Update: Core-amqp changes have been merged and should be part of the May release. The fix for service bus should be either May / June release