Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the artifact names and their dependencies before release #24722

Closed
Tracked by #23402
backwind1233 opened this issue Oct 11, 2021 · 3 comments · Fixed by #24940
Closed
Tracked by #23402

Review the artifact names and their dependencies before release #24722

backwind1233 opened this issue Oct 11, 2021 · 3 comments · Fixed by #24940
Assignees
@backwind1233
Labels
azure-spring All azure-spring related issues
Milestone
Spring Cloud Azur...

Comments

@backwind1233
Copy link
Contributor

backwind1233 commented Oct 11, 2021 •
edited by saragluna
Loading

Review the artifact names and their dependencies before release.

  • Go through all released artifacts, make sure they are following the same principle.
    • Make a table with new and old artifact names, compare with old names.
  • Investigate whether we need it or not, such as azure-spring-cloud-starter-cache and spring-cloud-azure-starter-eventhubs-kafka.
@backwind1233 backwind1233 mentioned this issue Oct 11, 2021
Closed
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2021
@backwind1233
Copy link
Contributor Author

Maybe book a meeting to discuss it is a good way.

@backwind1233 backwind1233 self-assigned this Oct 11, 2021
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Oct 11, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2021
@backwind1233 backwind1233 added this to the [2021] November milestone Oct 11, 2021
@saragluna
Copy link
Member

saragluna commented Oct 21, 2021 •
edited
Loading

After discussion with @stliu, we should remove the starters for cache and kafka. When users want to use Azure Redis or Azure Kafka, they could add the dependency of spring-cloud-azure-starter and the Spring Redis or Kafka starter directly, no need to use our starters.

@backwind1233 backwind1233 linked a pull request Oct 21, 2021 that will close this issue
Remove cache and eventhubs-kafka modules #24940
Merged
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@backwind1233
Copy link
Contributor Author

close this
there are two pr linked with this issue, they are all merged.
#25335
#24940

Repository owner moved this from Todo to Done in Spring Cloud Azure Nov 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@backwind1233 backwind1233

Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta
Development

Successfully merging a pull request may close this issue.

Remove cache and eventhubs-kafka modules Azure/azure-sdk-for-java
3 participants
@backwind1233 @chenrujun @saragluna