Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health Indicators for App Config. #25225

Closed
Tracked by #23402
saragluna opened this issue Nov 7, 2021 · 3 comments · Fixed by #25364
Closed
Tracked by #23402

Health Indicators for App Config. #25225

saragluna opened this issue Nov 7, 2021 · 3 comments · Fixed by #25364
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@saragluna
Copy link
Member

saragluna commented Nov 7, 2021 •
edited
Loading

The autoconfiguration of app config client is missing a health indicator, we should add it.
@saragluna saragluna mentioned this issue Nov 7, 2021
Closed
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 7, 2021
@saragluna saragluna added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Nov 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 7, 2021
@saragluna saragluna moved this to Todo in Spring Cloud Azure Nov 7, 2021
@saragluna saragluna added this to the [2021] December milestone Nov 7, 2021
@mrm9084
Copy link
Member

mrm9084 commented Nov 8, 2021

@saragluna Is this different than the already created ones?

@moarychan moarychan mentioned this issue Nov 12, 2021
Merged
@moarychan moarychan linked a pull request Nov 12, 2021 that will close this issue
Add app configuration health indicator #25364
Merged
@moarychan
Copy link
Member

moarychan commented Nov 12, 2021 •
edited
Loading

@saragluna Is this different than the already created ones?

Hi @mrm9084 It should be a new indicator using ConfigurationClient directly.

@moarychan moarychan moved this from Todo to In Progress in Spring Cloud Azure Nov 15, 2021
@moarychan moarychan moved this from In Progress to Done in Spring Cloud Azure Nov 17, 2021
@saragluna
Copy link
Member Author

Closing this issue now for #25364 has implemented it.

Yes @mrm9084, it's a different one for the level 1 SDK.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta
Development

Successfully merging a pull request may close this issue.

Add app configuration health indicator moarychan/azure-sdk-for-java
4 participants
@mrm9084 @chenrujun @moarychan @saragluna