[FEATURE REQ] DeleteOptions on Public Ip Address

[jloisel]

It's currently not possible to set DeleteOptions on a public ip address through the SDK, when creating it:

    final PublicIpAddress.DefinitionStages.WithCreate publicIp = publicIps
      .define(name)
      .withRegion(region)
      .withExistingResourceGroup(resourceGroup)
      .withoutLeafDomainLabel()
      .withoutReverseFqdn()
      .withSku(STANDARD)
      .withDynamicIP();

Would be useful to have it (as disk / network interfaces on a VM), to allow deleting the public ip automatically when the vm is deleted. As of now, we need to do this manually which is cumbersome.

[joshfree]

Thanks for filing this request, @jloisel. @weidongxu-microsoft could you help triage this

[weidongxu-microsoft]

@XiaofeiCao Do we know whether network RP behave correctly on this (delete IP address when delete VM)?

We can have Hong try it.

[XiaofeiCao]

According to my knowledge, deleteOption is only effective on NetworkInterface's PublicIpAddress property, not PublicIpAddress or VirtualMachine itself.
@v-hongli1 Would you help try whether deleteOption works on PublicIpAddress?

[v-hongli1]

@XiaofeiCao

1. I tried to fix the azure-resourcemanager-network interface and tested and found that deleteOption does not works on PublicIpAddress and does not return this item.
   The test result following as:
   PublicIPAccessTests.testCreateIPAccessWithDeleteOptionDelete.json
2. Now the deleteOption is also not supported on Public IP Address in the portal.

[XiaofeiCao]

@v-hongli1 Got it. The deleteOption may not be visible in the PublicIpAddress's properties, but it may ACTUALLY take effect.
Would you help confirm whether this deleteOption takes effect when deleting the VM that it attaches to(though if I remembered correctly, it does not)?

[v-hongli1]

@XiaofeiCao
Regardless of whether .withPrimaryNetworkInterfaceDeleteOptions(DeleteOptions.DELETE) is loaded when the virtual machine is created, the Public IP Address is not removed when the virtual machine is removed. I think Public IP Address may not contain deleteOption in its properties.

[weidongxu-microsoft]

@v-hongli1

It is in PublicIpAddress https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/resourcemanager/azure-resourcemanager-network/src/main/java/com/azure/resourcemanager/network/fluent/models/PublicIpAddressInner.java#L497-L499

But if it does not have effect, then it may not be supported yet (or have bug in backend).

Could you try this on portal and see if this deletes IpAddress when delete VM?

If yes, check the resource create by Portal.

[weidongxu-microsoft]

@XiaofeiCao Do you aware any other option that may help user delete the IpAdress with the VM?

[XiaofeiCao]

My experience is that the PublicIpAddress deleteOption is in NetworkInterface resource.

There's also a potential backend bug: If PublicIpAddress deleteOption is not set when attached to NetworkInterface(whether using RP's API or deployment template), it'll always be null, regardless of future updates(luckily Databricks has set deleteOption in their create deployment template)...
Azure/azure-rest-api-specs#25475
Our SDK didn't set this property during PublicIpAddress attach, so even update won't work.

For above reason, I'm afraid for now we'll have to wait for the feature to be added.

[XiaofeiCao]

@jloisel Due to service implementation limitation, the deleteOption should be set on the NetworkInterface that the PublicIpAddress is attached to.
Here's how to set PublicIpAddress delete option in NetworkInterface with latest 2.40.0 SDK:

// create nic with PublicIpAddress delete option
NetworkInterface nic = networkManager.networkInterfaces()
  .define(generateRandomResourceName("nic-", 15))
  .xx()
  .withNewPrimaryPublicIPAddress()
  .withPrimaryPublicIPAddressDeleteOptions(DeleteOptions.DELETE) // set primary publicIpAddress deleteOptions
  .create();

// update delete option
nic.update()
  .withPrimaryPublicIPAddressDeleteOptions(DeleteOptions.DELETE)
  .apply();

[github-actions]

Hi @jloisel. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[github-actions]

Hi @jloisel, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!