Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] mgmt, support convenience API for publicNetworkAccess #39310

Closed
5 tasks done
weidongxu-microsoft opened this issue Mar 20, 2024 · 3 comments
Closed
5 tasks done
Assignees
Labels
Mgmt This issue is related to a management-plane library.

Comments

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Mar 20, 2024

PR as example
https://github.com/Azure/azure-sdk-for-java/pull/39309/files

  • StorageAccount
  • CosmosDBAccount
  • KubernetesCluster
  • RedisCache
  • WebApp
  1. the inner model should have properties.publicNetworkAccess
  2. use the PublicNetworkAccess enum as response of the getter

Let me know if either of them does not apply.

Note

  1. no need to update PrivateLinkTests, we can update it after all complete
  2. one PR per module
@weidongxu-microsoft weidongxu-microsoft added the Mgmt This issue is related to a management-plane library. label Mar 20, 2024
@weidongxu-microsoft
Copy link
Member Author

@v-hongli1

Could you check if there is other class in premium libs that also need this support?

If no, you can close the issue.

@weidongxu-microsoft

This comment was marked as outdated.

@weidongxu-microsoft
Copy link
Member Author

Please search publicNetworkAccess() filter file *Inner.java.

See if it correlate to any handwritten class (usually a class without the Inner suffix) that not handled above.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

2 participants