Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unreleased versions in Spring compatibility-tests pipeline #41870

Closed
anuchandy opened this issue Sep 16, 2024 · 4 comments
Closed

Support unreleased versions in Spring compatibility-tests pipeline #41870

anuchandy opened this issue Sep 16, 2024 · 4 comments
Assignees
Labels
azure-spring All azure-spring related issues
Milestone

Comments

@anuchandy
Copy link
Member

The Spring compatibility-tests pipeline does not support unreleased versions. This is needed if some of the Azure libraries that Spring uses go through changes, and we want to validate those changes works correctly for Spring use cases before release.

Here is an example of PR that was failing when trying to run our Spring tests with unreleased versions of Service bus and Event Hubs.

Supporting unreleased requires copying existing logic for the From Source pipeline runs where it looks for unreleased dependencies.

Hi @saragluna, could you please help to triage?

@saragluna
Copy link
Member

@anuchandy thanks for bringing this up. If we enable this logic in our compatibility-tests, does it mean some jobs will still fail (the ones using the released versions), but the ones using the unreleased version will pass?

@saragluna saragluna added this to the 2024-10 milestone Sep 19, 2024
@anuchandy
Copy link
Member Author

Hi @saragluna, thanks for taking a look. The change simply allows our Spring tests to run using SB/EH/Core/* in main when instructed to do so by annotating with unreleased_com.azure. Once those are released, the spring poms will get updated to refer the same from maven. If we don't have any potential change to test, the dependencies will continue to be referenced from Maven as they are currently.

@saragluna
Copy link
Member

@anuchandy, okay got it. We will add one entry for it in our compatibility tests.

@Netyyyy
Copy link
Member

Netyyyy commented Sep 30, 2024

Fixed in #42025

@Netyyyy Netyyyy closed this as completed Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

No branches or pull requests

3 participants