Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Recommend using Boolean return type for API TokenCredentialOptionsProvider.TokenCredentialOptions#isManagedIdentityEnabled #43102

Open
2 tasks done
moarychan opened this issue Nov 26, 2024 · 0 comments
Labels
azure-spring All azure-spring related issues feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@moarychan
Copy link
Member

Is your feature request related to a problem? Please describe.
Recommend using Boolean return type for method TokenCredentialOptionsProvider.TokenCredentialOptions#isManagedIdentityEnabled, the properties bean copying is a bit annoying because the primitive type has a default value, and you can't be sure whether it is false configured by the user or the default value. It will be a break change.

Describe the solution you'd like
Boolean getManagedIdentityEnabled();

Describe alternatives you've considered
N/A

Additional context
N/A

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@moarychan moarychan added this to the Spring Cloud Azure 6.0 milestone Nov 26, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 26, 2024
@moarychan moarychan added the azure-spring All azure-spring related issues label Nov 26, 2024
@moarychan moarychan added the feature-request This issue requires a new behavior in the product in order be resolved. label Nov 26, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Status: Todo
Development

No branches or pull requests

1 participant