-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Storage APIs have a couple places where we do not allow the customer to pass a transactional md5 #4508
Comments
service feature |
@rickle-msft could you provide the details here for the questions you have for the arch board and @JonathanGiles can chime with his opinion and clarify whether this even needs to be reviewed by the entire arch board. |
@JonathanGiles The question that needs more formal guidance is on how we expose checksumming across the SDK. We completely omitted it in v11, but in v8, we had full support for it in a variety of scenarios. We exposed it as an optional parameter that could be attached to certain transactions and would be validated by the service upon receiving data (this is different from setting the Content MD5 property on the blob, which doesn't get validated at all). We also could calculate the MD5 on uploads and downloads and either set it with the final put call or check it against the received contentMD5 header after all the data had been streamed. These were fairly complicated operations that had considerations in the way of usability and performance. It's not clear to us whether we should pass options, accept a flag, provide a stand alone stream-wrapper that the customer should create themselves, etc. |
Decision was made in xstore sync meeting previously to just use MD5 for Java here. |
Closing. MD5 is a settable field. |
I noticed there are a couple places where we do not allow the customer to pass a transactional md5 |
Updating title to reflect the work that's actually being tracked with this issue |
Fixed by #5947 |
Closing now that #5947 has been merged. |
Investigate Java's ability to support a custom polynomial for CRC.May fall back to MD5 if this is not possible.Needs arch board guidance for checksumsThe text was updated successfully, but these errors were encountered: