Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Queue and File service client. #4532

Closed
sima-zhu opened this issue Jul 22, 2019 · 4 comments
Closed

Rename Queue and File service client. #4532

sima-zhu opened this issue Jul 22, 2019 · 4 comments
Assignees
@sima-zhu
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@sima-zhu
Copy link
Contributor

No description provided.

@sima-zhu sima-zhu self-assigned this Jul 22, 2019
@sima-zhu sima-zhu added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 22, 2019
@sima-zhu sima-zhu mentioned this issue Jul 22, 2019
Closed
@alzimmermsft alzimmermsft mentioned this issue Jul 23, 2019
Closed
20 tasks
@sima-zhu sima-zhu mentioned this issue Jul 23, 2019
Merged
@sima-zhu
Copy link
Contributor Author

Leave FileServiceProperties as it is for first PR as it asked swagger change

@sima-zhu sima-zhu mentioned this issue Aug 9, 2019
Closed
@tg-msft
Copy link
Member

tg-msft commented Aug 12, 2019

.NET currently has BlobServiceClient/QueueServiceClient/FileServiceClient. We discussed BlobStorageClient a long time ago and back then BlobServiceClient was preferred. I don't feel strongly and can move to whatever the Storage team prefers.

@HarshaNalluru
Copy link
Member

Just like the .NET, JS names are BlobServiceClient/QueueServiceClient/FileServiceClient currently.
Need to discuss this with storage JS team and know their opinions.

@kurtzeborn
Copy link
Member

XStore team's preference is to do another preview using the *ServiceClient naming convention and see if there is even one comment about this being confusing. If there is we'll revisit.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sima-zhu sima-zhu

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tg-msft @HarshaNalluru @kurtzeborn @sima-zhu