Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify JavaDocThrowsCheck to sync up with ThrowFromClientLoggerCheck #4708

Closed
mssfang opened this issue Jul 30, 2019 · 1 comment
Closed

Modify JavaDocThrowsCheck to sync up with ThrowFromClientLoggerCheck #4708

mssfang opened this issue Jul 30, 2019 · 1 comment
Assignees
@mssfang
Labels
Client This issue points to a problem in the data-plane of the library. Java Source Code Rules

Comments

@mssfang
Copy link
Member

mssfang commented Jul 30, 2019

Feedback from Alan and Jonathon.:
ThrowFromClientLoggerCheck breaks the JavaDocThrowsCheck logic as that was checking for LITERAL_THROW and those will be going away.
The JavaDocThrowsCheck will need updating to understand the logAndThrow pattern to make sure we document these exceptions in JavaDoc.
@mssfang mssfang self-assigned this Jul 30, 2019
@mssfang mssfang mentioned this issue Jul 30, 2019
Merged
@Petermarcu Petermarcu added the EngSys This issue is impacting the engineering system. label Jul 30, 2019
@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. and removed EngSys This issue is impacting the engineering system. labels Aug 21, 2019
@mssfang
Copy link
Member Author

mssfang commented Aug 27, 2019

now we change to allow to throw logAndThrow

@mssfang mssfang closed this as completed Aug 27, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mssfang mssfang

Labels
Client This issue points to a problem in the data-plane of the library. Java Source Code Rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Petermarcu @kurtzeborn @mssfang