Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@azure/attestation has an incorrectly defined types path #15727

Closed
scbedd opened this issue Jun 14, 2021 · 6 comments · Fixed by #15736
Closed

@azure/attestation has an incorrectly defined types path #15727

scbedd opened this issue Jun 14, 2021 · 6 comments · Fixed by #15736
Assignees
@deyaaeldeen
Labels
Attestation Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] July

Comments

@scbedd
Copy link
Member

scbedd commented Jun 14, 2021

here it is installed:

image

Either attestation.d.ts belongs under a latest folder, or the path needs to be updated to remove latest.

Discovered via failing doc build.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 14, 2021
@scbedd
Copy link
Member Author

scbedd commented Jun 14, 2021

Manual Fix In Interim

@ramya-rao-a ramya-rao-a added Attestation Client This issue points to a problem in the data-plane of the library. labels Jun 14, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 14, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] July milestone Jun 14, 2021
@deyaaeldeen deyaaeldeen mentioned this issue Jun 14, 2021
Merged
@deyaaeldeen
Copy link
Member

I created a fix here: #15736

@deyaaeldeen
Copy link
Member

@scbedd it is fixed now, I will see if I can make a release.

@deyaaeldeen deyaaeldeen mentioned this issue Jun 15, 2021
Merged
@jeremymeng
Copy link
Member

Is/should there be a linting rule for this?

@deyaaeldeen
Copy link
Member

@jeremymeng not yet, here is the tracking issue: #13224

@scbedd
Copy link
Member Author

scbedd commented Jun 15, 2021

@deyaaeldeen thank you! There is no rush to send a new release, as we do have the necessary dials to turn on this package. We'll just want to verify that everything is g2g after beta.4 is released. 👍

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Attestation Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[Attestation] Fix types path deyaaeldeen/azure-sdk-for-js
4 participants
@deyaaeldeen @jeremymeng @ramya-rao-a @scbedd