Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity createSpan #16806

Closed
KarishmaGhiya opened this issue Aug 7, 2021 · 0 comments · Fixed by #18076
Closed

Identity createSpan #16806

KarishmaGhiya opened this issue Aug 7, 2021 · 0 comments · Fixed by #18076
Assignees
@KarishmaGhiya
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] November

Comments

@KarishmaGhiya
Copy link
Member

CreateSpan should follow the following format - clientName-MethodName. Some use a "." instead they should be changed to using "-"
eg : CredentialName-getToken

Also for credentials like ChainedTokenCredentials and DefaultAzureCredentials that can be used as base classes by other creds
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 7, 2021
@KarishmaGhiya KarishmaGhiya mentioned this issue Aug 7, 2021
Merged
@KarishmaGhiya KarishmaGhiya self-assigned this Aug 7, 2021
@KarishmaGhiya KarishmaGhiya added the Client This issue points to a problem in the data-plane of the library. label Aug 7, 2021
@KarishmaGhiya KarishmaGhiya mentioned this issue Oct 7, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] November
Development

Successfully merging a pull request may close this issue.

update tracing for consistency KarishmaGhiya/azure-sdk-for-js
2 participants
@sadasant @KarishmaGhiya