Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engsys] update dev dependency mocha-junit-reporter #17098

Closed
jeremymeng opened this issue Aug 24, 2021 · 3 comments
Closed

[engsys] update dev dependency mocha-junit-reporter #17098

jeremymeng opened this issue Aug 24, 2021 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@jeremymeng
Copy link
Member

No description provided.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 24, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Aug 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 24, 2021
@jeremymeng jeremymeng added this to the Backlog milestone Aug 24, 2021
@jeremymeng jeremymeng mentioned this issue Aug 24, 2021
Closed
@ramya-rao-a
Copy link
Contributor

@HarshaNalluru This is related to code coverage?
Have we investigated moving to v2 before?

And looks like this is imported only in the https://github.com/Azure/azure-sdk-for-js/blob/e823b26f4600a698eb1c06f48da9b780fb2331a7/common/tools/mocha-multi-reporter.js

Any reason why each package needs to take a dependency on it?

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Aug 26, 2021 •
edited
Loading

The file is common to all the packages, so was pulled out. All that the common file does is avoiding duplication.
We need the dependency for the reporter to work with the mocha command.

@jeremymeng
Copy link
Member Author

Closing in favor of bot-auto-filed issue #19227

@jeremymeng jeremymeng mentioned this issue Dec 13, 2021
Closed
@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xirzec @jeremymeng @HarshaNalluru @ramya-rao-a