-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[engsys] upgrade dev dependency typescript #17776
Comments
I played with this a little bit and found that we will need to upgrade the api extractor first to v7.18.11 to play well with typescript@4.4. Otherwise, v7.7.11 will throw |
Thank you @deyaaeldeen for the heads up! It does sound like upgrading API Extractor is something we are bumping into a few times already. I spoke to @xirzec and @ramya-rao-a and we should just rip the band-aid out and do the upgrade. I'll take #9410 and will likely complete it early October - hopefully that works with your schedule? |
@maorleger thanks a lot for doing this! That definitely works! |
Most packages have been moved to v4.6. Codegen is also updated to use v4.6 in generated code. There are some track1 packages that remain untouched. We will keep them that way. |
Move to TypeScript 4.4
Major breaking issue: TypeScript 4.4 introduces a new flag called
--useUnknownInCatchVariables
. This flag changes the default type ofcatch
clause variables fromany
tounknown
.we could use this flag to opt in as we are fixing libraries gradually.
This issue tracks the work to upgrade to 4.4 and use the flag to disable the check in the shared tsconfig.
Fix option 1:
Fix option 2:
Personally I prefer option 1 over option 2 because option 2 just get rid of the compilation error but doesn't get any benefits from enabling the option..
The text was updated successfully, but these errors were encountered: