Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engsys] rushx audit failing #22832

Closed
jeremymeng opened this issue Aug 5, 2022 · 1 comment
Closed

[engsys] rushx audit failing #22832

jeremymeng opened this issue Aug 5, 2022 · 1 comment
Labels
EngSys This issue is impacting the engineering system.

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Aug 5, 2022

because our dev dependencies dev-tool and eslint-plugin v3 haven't been published to npm. One could work around by temporarily removing the two dev dependencies.

Some question:

  • Should we remove the "audit" NPM script? I am not sure who is running this nowadays, given that it is broken, and nobody complains. We have Component Governance that reports security issues.

  • If we want to keep it, we could fix it by publishing the two dependencies.

    • eslint-plugin v2 is on NPM. Need to publish v3
    • dev-tool is mostly internal, can go under @azure-tool/ scope. We have test-recorder under that.
@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label Aug 5, 2022
Copy link

github-actions bot commented Aug 5, 2024

Hi @jeremymeng, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

1 participant