Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication - Calling] TeamsCallAgent.dispose() fails in 1.15.1-beta.1 #26414

Closed
2 of 6 tasks
JasonWeinzierl opened this issue Jul 6, 2023 · 3 comments
Closed
2 of 6 tasks
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Communication - Calling Server customer-reported Issues that are reported by GitHub users external to the Azure organization.

Comments

@JasonWeinzierl
Copy link

JasonWeinzierl commented Jul 6, 2023

  • Package Name: @azure/communication-calling
  • Package Version: 1.15.1-beta.1
  • Operating system: macOS
  • nodejs
    • version:
  • browser
    • name/version: Chrome 114.0.5735.198
  • typescript
    • version: 5.1.6
  • Is the bug related to documentation in

Describe the bug

When disposing a call agent, a TypeError is thrown: TypeError: Cannot read properties of undefined (reading 'offStateChanged')

To Reproduce

Steps to reproduce the behavior:

const callClient = new CallClient();
const credential = ... ; // create a token credential

const teamsCallAgent = await callClient.createTeamsCallAgent(credential);

teamsCallAgent.dispose();  // TypeError

Expected behavior

Disposing call agent should not cause a TypeError.

Screenshots

N/A

Additional context

Stack trace:

TypeError: Cannot read properties of undefined (reading 'offStateChanged')
    at CallStack.offTrouterStateChanged (sdk.bundle.js:196:809580)
    at TeamsCallAgentImpl.offTrouterStateChanged (sdk.bundle.js:196:591843)
    at TeamsCallAgentImpl.<anonymous> (sdk.bundle.js:196:859643)

This does not happen in previous version of the SDK.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 6, 2023
@xirzec xirzec added Communication - Calling Server Client This issue points to a problem in the data-plane of the library. labels Jul 6, 2023
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 6, 2023
@xirzec xirzec added bug This issue requires a change to an existing behavior in the product in order to be resolved. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 6, 2023
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 6, 2023
@stevebrisson-librestream
Copy link

stevebrisson-librestream commented Jul 17, 2023

I would just like to add that this happens with the regular CallAgent created from the createCallAgent method call as well.

@JasonWeinzierl
Copy link
Author

Seems to be fixed in 1.15.2-beta.1

@fizampou
Copy link
Member

This issue is fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Communication - Calling Server customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

No branches or pull requests

5 participants