Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Update package.json files to have sideEffects set to false #2653

Closed
ramya-rao-a opened this issue May 2, 2019 · 1 comment
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 2, 2019

As per the Typescript guidelines, we need to set sideEffects to false in the package.json files.

Relevant section from the guidelines

DO set sideEffects to false. Side effecting libraries must be explicitly approved during design review. The sideEffects field is used by Webpack and potentially other tools as an indicator of how aggressively the package can be optimized.

Side effects refer to modifications to the runtime environment of the program as a result of including a module. For example, including a polyfill library is a sideEffect as it mutates the global environment and later code depends on its presence. Side effects make it harder for tools to optimize your build and should be avoided

This issue is to track the required update in both EPH and Event Hubs

@ramya-rao-a ramya-rao-a changed the title Update package.json files to have sideEffects set to false [Event Hubs] Update package.json files to have sideEffects set to false May 2, 2019
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 2, 2019
@triage-new-issues triage-new-issues bot removed the triage label May 2, 2019
@ramya-rao-a ramya-rao-a added this to the Sprint 152 milestone May 7, 2019
@ShivangiReja ShivangiReja self-assigned this May 8, 2019
@ShivangiReja
Copy link
Member

Closed with #2767

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants