-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] Requests are not retried when link creation fails #2835
Labels
Milestone
Comments
ramya-rao-a
added
Client
This issue points to a problem in the data-plane of the library.
Event Hubs
labels
May 12, 2019
This was referenced May 12, 2019
This also depends on #2891 because one type of error during link creation is timeouts. |
5 tasks
ramya-rao-a
changed the title
[Event Hubs] Pass retry options to link creation
[Event Hubs] Requests are not retried when link creation fails
Jul 11, 2019
Generally, we should ensure that we retry user requests when any step inside the request fails with retryable error. Since all other steps inside the request are already covered and link creation is the only one left, this issue is specifically talking about failures during link creation. |
This was referenced Jul 11, 2019
This was referenced Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
There are 3 kinds of requests on the
EventHubClient
that use 3 different linkssend()
requestsreceive()
andreceiveBatch()
requestsAssume that the link creation act fails with a retryable error for the above requests.
Among all the requests,
receiveBatch()
is the only one that retries.The other requests (
send()
,recieve()
, and operations on $management link) will not retry in this case. This goes against the promise we are making to our customers that if their requests (send()
,recieve()
, and operations on $management link) fails with a retryable error, then we will retry their requestsThe text was updated successfully, but these errors were encountered: