Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Implement createSender() end to end #3170

Closed
ramya-rao-a opened this issue May 23, 2019 · 1 comment
Closed

[Event Hubs] Implement createSender() end to end #3170

ramya-rao-a opened this issue May 23, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 23, 2019

As per the API proposal in #2718 (comment), we will now have a createSender() method on the Event Hub Client that returns a sender. A skeleton is already in place for the sender. This issue is to ensure

  • That the send method and all its overloads work as expected
  • Parameter validations are done as per guidelines
  • All applicable tests in sender.spec.ts are updated and pass

Please note that this issue only ensures that the send operation on the sender works. We need to ensure #3172 is taken care of to call this feature of "createSender" actually complete.

@ramya-rao-a
Copy link
Contributor Author

Completed with #3177

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants