Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification-hubs] Add file entries for @azure/arm-notificationhubs #32259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/arm-notificationhubs

Issues associated with this PR

Describe the problem that is addressed by this PR

Adds back in the review folder and the CHANGELOG back to the npm package files.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 17, 2024
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kazrael2119
Copy link
Contributor

ci failure may be caused by this commit 16d22bd#diff-a7f4ca2b73e5e064db3afb079f7ec3d46fec30aa4f2791a8af32e5742667643fR39

notificationhubs doesn't have tsconfig.test.json file after migrating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants