Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to generate emitter sdk due to npm list --all failed in eng/common/scripts/typespec/New-EmitterPackageLock.ps1 #32518

Open
3 of 6 tasks
wanlwanl opened this issue Jan 13, 2025 · 2 comments · May be fixed by #32545
Open
3 of 6 tasks

Failed to generate emitter sdk due to npm list --all failed in eng/common/scripts/typespec/New-EmitterPackageLock.ps1 #32518

wanlwanl opened this issue Jan 13, 2025 · 2 comments · May be fixed by #32545
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@wanlwanl
Copy link
Member

  • Package Name: n/a
  • Package Version: n/a
  • Operating system: not related
  • nodejs
    • version:
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
A clear and concise description of what the bug is.
npm list --all reports missing @typespec/openapi while it's already in TCGC
Since TCGC uses rush+pnpm, I guess it causes npm failed to parse dependency.
Can we delete this command?

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4471844&view=logs&j=739bb7ec-7296-5b40-7dff-ee3297bfdaa4&t=e86df87d-35b0-5d39-3a9f-d53f39de3dbe&l=26

To Reproduce
Steps to reproduce the behavior:

  1. run pipeline https://dev.azure.com/azure-sdk/internal/_build?definitionId=6415

Expected behavior
A clear and concise description of what you expected to happen.
pipeline success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=6415

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

azure-sdk-for-js/eng/common/scripts/typespec/New-EmitterPackageLock.ps1

Line 47 in 886050e

npm list --all

@wanlwanl
Copy link
Member Author

CC @qiaozha and @tadelesh

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2025
@jeremymeng jeremymeng added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. and removed EngSys This issue is impacting the engineering system. labels Jan 13, 2025
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2025
@MaryGao
Copy link
Member

MaryGao commented Jan 14, 2025 •
edited
Loading

@hallipr May I know why we enabled the flag legacy-peer-deps in refreshing script?

azure-sdk-for-js/eng/common/scripts/typespec/New-EmitterPackageLock.ps1

Line 39 in 886050e

npm install --legacy-peer-deps

I think the issue happened that tcgc has a peer dependency with @typespec/openapi but actually JS emitter doesn't require that one. Usually if we install with npm install, these peer dependencies would be automatically installed. However if we turned on that flag we may need to add these downstream peers which actually we don't necessarily need also in our emitter side.

My concern is we build the unnecessary dependency coupling between them.

@v-jiaodi v-jiaodi linked a pull request Jan 14, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Status: 🤔 Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update package config v-jiaodi/azure-sdk-for-js
3 participants
@jeremymeng @MaryGao @wanlwanl