Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArchBoard Feedback] Rename StorageServiceProperties to QueueServiceProperties #3480

Closed
jeremymeng opened this issue Jun 5, 2019 · 3 comments
Closed

[ArchBoard Feedback] Rename StorageServiceProperties to QueueServiceProperties #3480

jeremymeng opened this issue Jun 5, 2019 · 3 comments
Assignees
@jeremymeng
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Milestone
Sprint 157

Comments

@jeremymeng
Copy link
Member

and StorageServiceStats to QueueServiceStats. It might involve modifying autorest code gen

Or easier: aliasing the old types to new names.
@jeremymeng jeremymeng added this to the Sprint 154 milestone Jun 5, 2019
@jeremymeng jeremymeng self-assigned this Jun 5, 2019
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jun 5, 2019
@jeremymeng jeremymeng changed the title Rename StorageServiceProperties to QueueServiceProperties [ArchBoard Feedback] Rename StorageServiceProperties to [QueueServiceProperties Jun 5, 2019
@jeremymeng jeremymeng mentioned this issue Jun 5, 2019
Closed
@jeremymeng
Copy link
Member Author

Postponed after Preview 1

@ramya-rao-a ramya-rao-a mentioned this issue Aug 2, 2019
Closed
14 tasks
@AlexGhiondea AlexGhiondea modified the milestones: Sprint 154, Sprint 157 Aug 13, 2019
@jeremymeng
Copy link
Member Author

When we used the unified swagger json we should be getting the same names across languages. No need to do extra work here.

@jeremymeng
Copy link
Member Author

.NET is using transformation directive. https://github.com/Azure/azure-sdk-for-net/tree/87a4cc0f274af18af4bcda5deaf97668170d28bb/sdk/storage/Azure.Storage.Blobs/swagger#restypeservicecompproperties
We should do similar too.

@jeremymeng jeremymeng reopened this Oct 7, 2019
@jeremymeng jeremymeng changed the title [ArchBoard Feedback] Rename StorageServiceProperties to [QueueServiceProperties [ArchBoard Feedback] Rename StorageServiceProperties to QueueServiceProperties Oct 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
Sprint 157
Development

No branches or pull requests
2 participants
@jeremymeng @AlexGhiondea