Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-amqp] [Event Hubs] Long-term solution for OperationTimeoutError handling #4206

Closed
ramya0820 opened this issue Jul 8, 2019 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@ramya0820
Copy link
Member

ramya0820 commented Jul 8, 2019

Based on work being done as part of #4171, we have decided to tryout making changes in core-amqp to pass in OperationTimeoutInMs along with changes in for at least EventHubs before concluding fix for #4171 (so we can verify handling of all affected usecases).

As discussed offline, this issue is used to track changes required in core-amqp and EventHubs for the more right, long-term approach proposed for #4171

Once this concludes, depending on complexity involved, we can move ahead to update Service Bus (Track 2) if applicable.

@ramya0820
Copy link
Member Author

Based on investigation done for #2891 (If OperationTimeoutError is to be retryable or not), some conclusions have been captured at #2891 (comment) that are applicable to identifying what are the affected operations that need to be updated.

Current efforts to test changes in EventHubs would help with it as well.

@ramya0820 ramya0820 added Event Hubs Client This issue points to a problem in the data-plane of the library. and removed triage labels Jul 8, 2019
@ramya0820 ramya0820 changed the title [Event Hubs] Changes to adopt newer implementation of OperationTimeoutError handling [Event Hubs] Long-term solution for OperationTimeoutError handling Jul 9, 2019
@ramya0820 ramya0820 changed the title [Event Hubs] Long-term solution for OperationTimeoutError handling [core-amqp] [Event Hubs] Long-term solution for OperationTimeoutError handling Jul 9, 2019
@ramya-rao-a
Copy link
Contributor

It is now known that using this approach and ensuring that Event Hubs and Service Bus can continue to work as expected is not trivial.

Based on current bandwidth, we don't have time to explore this approach at the moment.

There are talks about having a pipeline for amqp libraries just like we do for http, in which case retry policy and implementations will be re-visited and re-factored at which point it would be expected for the retry() to implement its own timer.

Therefore, closing this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants