Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or suppress warnings in unit-test command #4278

Closed
mikeharder opened this issue Jul 11, 2019 · 5 comments
Closed

Fix or suppress warnings in unit-test command #4278

mikeharder opened this issue Jul 11, 2019 · 5 comments
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@mikeharder
Copy link
Member

mikeharder commented Jul 11, 2019

The command rush unit-test generates 4 warnings. These warnings add noise to the build log, and cause build failures in Rush 5.9.0 and later.

SUCCESS WITH WARNINGS (4)
================================
@azure/identity (4.76 seconds)
Excluding: "/home/vsts/work/1/s/sdk/identity/identity/test-browser/index.js"

@azure/storage-blob (1 minute 13.4 seconds)
Excluding: "/home/vsts/work/1/s/sdk/storage/storage-blob/dist-test/index.browser.js"

@azure/storage-file (1 minute 10.1 seconds)
Excluding: "/home/vsts/work/1/s/sdk/storage/storage-file/dist-test/index.browser.js"

@azure/storage-queue (1 minute 2.6 seconds)
Excluding: "/home/vsts/work/1/s/sdk/storage/storage-queue/dist-test/index.browser.js"
================================

https://dev.azure.com/azure-sdk/public/_build/results?buildId=65710&view=logs&j=5aded954-f3f8-5654-771c-2734fb7ecea6&t=bfb220ef-950d-5fe9-00e0-4eac6f5034d1&l=2940

@daviwil
Copy link
Contributor

daviwil commented Jul 11, 2019

Thanks Mike! I'll take a look.

@mikeharder
Copy link
Member Author

@daviwil: We fixed this in some commands by just redirecting STDERR to STDOUT (2>&1):

"build": "tsc -p . && rollup -c 2>&1",

@daviwil
Copy link
Contributor

daviwil commented Jul 11, 2019

Yep, I'll go that route if I can verify for sure that Karma isn't trying to tell us about an actual problem.

@kurtzeborn kurtzeborn added EngSys This issue is impacting the engineering system. and removed triage labels Jul 15, 2019
@kurtzeborn kurtzeborn added Azure.Identity Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) and removed EngSys This issue is impacting the engineering system. labels Jul 23, 2019
@kurtzeborn kurtzeborn assigned daviwil and unassigned KarishmaGhiya Jul 23, 2019
@jeremymeng
Copy link
Member

We have #3993 tracking rollup warning for storage. Removing storage label from this.

@jeremymeng jeremymeng removed the Storage Storage Service (Queues, Blobs, Files) label Sep 16, 2019
@ramya-rao-a ramya-rao-a added this to the [2020] January milestone Nov 8, 2019
@xirzec xirzec modified the milestones: [2020] February, Backlog Feb 11, 2020
@ramya-rao-a
Copy link
Contributor

Like @jeremymeng mentioned, we have #3993 for tracking the warnings from building storage tests
#9855 and #9897 will fix the warnings from building identity code and tests

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

7 participants