Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch] Review codesnippets in README #4290

Closed
ramya-rao-a opened this issue Jul 12, 2019 · 2 comments
Closed

[Batch] Review codesnippets in README #4290

ramya-rao-a opened this issue Jul 12, 2019 · 2 comments
Assignees
@joheredi
Labels
Batch Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] June

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 12, 2019 •
edited
Loading

The code-snippets in README for libraries that are auto-generated have also been auto-generated.
This issue is to review these code-snippets and to ensure that they are accurate among the data plane library for Azure Batch

Related to #4291
@ramya-rao-a ramya-rao-a added Batch Client This issue points to a problem in the data-plane of the library. labels Jul 12, 2019
@ramya-rao-a ramya-rao-a added this to the Sprint 157 milestone Jul 12, 2019
@ramya-rao-a ramya-rao-a modified the milestones: Sprint 157, [2020] March Jan 30, 2020
@joheredi joheredi modified the milestones: [2020] March, [2020] May Mar 30, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] May, [2020] June May 14, 2020
@joheredi
Copy link
Member

joheredi commented May 15, 2020 •
edited
Loading

@ramya-rao-a I have reviewed the snippets. They are valid, just needed a few missing imports, included these changes in #8380

@ramya-rao-a
Copy link
Contributor Author

Thanks @joheredi!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joheredi joheredi

Labels
Batch Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] June
Development

No branches or pull requests
2 participants
@ramya-rao-a @joheredi