Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Optional abortSignal in storage packages #4570

Closed
HarshaNalluru opened this issue Jul 31, 2019 · 1 comment
Closed

[Storage] Optional abortSignal in storage packages #4570

HarshaNalluru opened this issue Jul 31, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@HarshaNalluru
Copy link
Member

#4502 (comment)

abortSignal param is optional in the options passed to some of the methods in storage packages, still, we initialize it with Aborter.none (or AbortSignal.none) even though it's not needed.
This issue is to track all the places we do this and to update.

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 31, 2019
@jeremymeng
Copy link
Member

we initialize it with Aborter.none (or AbortSignal.none) even though it's not needed.

when we made it optional we thought Aborter.none is a good default value. However, passing the optional abort signal through should be working as well.

@jeremymeng jeremymeng self-assigned this Sep 4, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

2 participants