Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-file] 10.2.0 uploadFileToAzureFile function throws error "TypeError: fetch is not a function" #5033

Closed
ringberg opened this issue Sep 6, 2019 · 12 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@ringberg
Copy link

ringberg commented Sep 6, 2019

10.1.0 seems to be working

@bterlson
Copy link
Member

bterlson commented Sep 6, 2019

Where are you seeing this error (what browser version/node version)?

@kaerm kaerm added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Sep 6, 2019
@triage-new-issues triage-new-issues bot removed the triage label Sep 6, 2019
@XiaoningLiu
Copy link
Member

@felixringbergbabyshop Can you provide a simple sample for reproducing?

@jeremymeng jeremymeng added the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 1, 2019
@jeremymeng
Copy link
Member

This also repros in v10.

@mrsufgi
Copy link

mrsufgi commented Oct 29, 2019

  "name"  :  "TypeError" ,
     "stack"  :  "TypeError: fetch is not a function
    at NodeFetchHttpClient.<anonymous> (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/es/lib/nodeFetchHttpClient.js:25:1)
    at step (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:99:1)
    at Object.next (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:80:45)
    at /bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:73:1
    at new Promise (<anonymous>)
    at __awaiter (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:69:1)
    at NodeFetchHttpClient.fetch (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/es/lib/nodeFetchHttpClient.js:23:16)
    at NodeFetchHttpClient.<anonymous> (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/es/lib/fetchHttpClient.js:104:1)
    at step (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:99:1)
    at Object.next (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:80:45)
    at fulfilled (/bin/webpack:/home/circleci/circleci-deployment/node_modules/@azure/storage-blob/node_modules/@azure/ms-rest-js/node_modules/tslib/tslib.es6.js:70:42)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)" ,

v10.5.0

to add more background, we are using typescript and the issue doesn't occur when we run it on dev server locally. only after we build and deploy we get this error. with preview5 not working for prod and 10.5 not working for prod I guess we will try going back to 10.1.0.

@zhusijia26 zhusijia26 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Oct 29, 2019
@ramya-rao-a
Copy link
Contributor

@XiaoningLiu Do you have any leads on this?

@ramya-rao-a ramya-rao-a added this to the [2020] January milestone Nov 19, 2019
@XiaoningLiu
Copy link
Member

fetch is a method in NodeFetchHttpClient provided in @azure/core-http, which not directly depended by convenience layer.
https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-http/lib/fetchHttpClient.ts

I cannot reproduce this in my environment. @jeremymeng What's your reproduce steps?

@jeremymeng
Copy link
Member

@jeremymeng What's your reproduce steps?

Sorry I don't remember repro'ing this issue. My earlier comments might have been based on the report, or was meant for another different issue.

@kartikshah9
Copy link

What are the next steps for this issue? Do we need additional inputs from customer - @XiaoningLiu

@jeremymeng
Copy link
Member

@XiaoningLiu any changes between v10.1.0 and v10.2.0 that might be related?

@zhusijia26
Copy link

@XiaoningLiu could you please help understand what is pending for this issue? Thanks!

@XiaoningLiu
Copy link
Member

@zhusijia26 Issue cannot be reproduced in my side. Needs more inputs from customer or we may close the issue.

@zhusijia26
Copy link

@felixringbergbabyshop could you please provide more information to let us reproduce the issue? I am closing the ticket at this moment, but whenever you have more detail, please reopen. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

10 participants