Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][core-http] createPipelineFromOptions needs a way to skip retry policies #5804

Closed
xirzec opened this issue Oct 25, 2019 · 2 comments
Closed
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@xirzec
Copy link
Member

xirzec commented Oct 25, 2019

Currently there is no good way to disable the built-in retry logic when using createPipelineFromOptions:

This makes it tricky for Storage to apply its custom retry policies. For now we are relying on the fact that these policies are always the last three, but in the future it would be nice to have some way to identify these policies in the array (so they can be removed or inserted before/after)

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Oct 25, 2019
@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Dec 16, 2019
@bterlson
Copy link
Member

We should solve this problem of libraries subclassing ServiceClient and needing custom pipelines before exposing this machinery to users.

@xirzec
Copy link
Member Author

xirzec commented Mar 17, 2021

This can be easily done with core-rest-pipeline, so new service clients built on top will be able to configure it

@xirzec xirzec closed this as completed Mar 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

5 participants