Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-http] Consider switching from tunnel to another proxy agent library #6773

Closed
daviwil opened this issue Jan 4, 2020 · 2 comments
Closed
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 4, 2020

While working on PR #6772 I had a hard time figuring out how TLS settings get propagated from tunnel's options types down to the underlying HTTP(S) connections. While looking into this, I happened across the node-https-proxy-agent library which is simpler, clearer, and seemingly more robust. I think it would be wise to switch to it (or another alternative) since tunnel is currently at a not-confidence-inspiring version 0.0.6 and seemingly not actively maintained.

One concern @bterlson raised offline is whether other proxy libraries like node-https-proxy-agent support HTTPS over HTTPS proxy connections; based on what I see in the README.md of the repository, this seems to be supported.

@amarzavery - Do you remember why tunnel was chosen over other options for ms-rest-js?

/cc @southpolesteve @xirzec

@southpolesteve
Copy link
Contributor

FYI We recommend https://github.com/TooTallNate/node-proxy-agent to Cosmos users. Same author as the one you linked above.

@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Jan 7, 2020
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jan 7, 2020
@xirzec xirzec modified the milestones: [2020] March, Backlog Mar 9, 2020
@xirzec
Copy link
Member

xirzec commented Jul 27, 2020

core-https uses node-proxy-agent. I don't think it's worth going back and modifying the existing core-http though, so I'm going to close out this issue.

@xirzec xirzec closed this as completed Jul 27, 2020
@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

4 participants