Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-http] Remove custom URL implementation #8620

Closed
xirzec opened this issue Apr 30, 2020 · 3 comments
Closed

[core-http] Remove custom URL implementation #8620

xirzec opened this issue Apr 30, 2020 · 3 comments
Assignees
@xirzec
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@xirzec
Copy link
Member

xirzec commented Apr 30, 2020

Node provides a browser-compatible URL class. We should be able to use it in place of our custom implementation.
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Apr 30, 2020
@xirzec xirzec added this to the [2020] June milestone Apr 30, 2020
@xirzec xirzec self-assigned this Apr 30, 2020
@xirzec xirzec mentioned this issue Apr 30, 2020
Closed
35 tasks
@xirzec xirzec modified the milestones: [2020] June, Backlog May 6, 2020
@xirzec
Copy link
Member Author

xirzec commented May 22, 2020

I already have a working form of this in the new core-http lib (check out core-https)

@xirzec
Copy link
Member Author

xirzec commented Jun 18, 2020

See #9082 - though there may be some behavior specific to autorest's path building that needs to be supported

@xirzec
Copy link
Member Author

xirzec commented Jul 27, 2020

This was achieved in core-client and core-https

@xirzec xirzec closed this as completed Jul 27, 2020
@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xirzec xirzec

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xirzec