Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme content of Azure Event Hubs is unclear #8798

Closed
zzhxiaofeng opened this issue May 8, 2020 · 1 comment
Closed

Readme content of Azure Event Hubs is unclear #8798

zzhxiaofeng opened this issue May 8, 2020 · 1 comment
Assignees
@ramya-rao-a @chradek
Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Milestone
[2020] June

Comments

@zzhxiaofeng
Copy link
Contributor

zzhxiaofeng commented May 8, 2020 •
edited
Loading

1
Section link
Annotation 2020-05-07 103108
Comment: Correct it as const { EventHubConsumerClient, earliestEventPosition } = require("@azure/event-hubs"); to use "earliestEventPosition" in code.

2
Section link
Annotation 2020-05-07 105423
Comment: Correct it as Event Hub-compatible endpoint (e.g. "Endpoint=sb://my-iothub-namespace-[uid].servicebus.windows.net/;SharedAccessKeyName=my-SA-name;SharedAccessKey=my-SA-key;EntityPath=my-iot-hub-name")
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 8, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 8, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 8, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 8, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] June milestone May 8, 2020
@ramya-rao-a ramya-rao-a self-assigned this May 8, 2020
@chradek chradek mentioned this issue Jun 5, 2020
Merged
@chradek
Copy link
Contributor

chradek commented Jun 8, 2020

Thanks for reporting this issue! We've made both changes you've suggested and have published version 5.2.1 of the @azure/event-hubs package with these changes.

@chradek chradek closed this as completed Jun 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

@chradek chradek

Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Projects
None yet
Milestone
[2020] June
Development

No branches or pull requests
3 participants
@ramya-rao-a @zzhxiaofeng @chradek